Andrew Wong

Results 45 comments of Andrew Wong

> Also don't forget to mark params are nonnull and add Validate checks I added the class-level annotation `ParamsAreNonnullByDefault`, is that accepted or must I annotate the params individually?

Totally forgot about this, will push some changes in the next few days

I'm gonna leave a comment here before I push the commit which changes Validate for Preconditions. I can see Validate being used in other SF classes (ex: `package io.github.thebusybiscuit.slimefun4.utils.biomes.BiomeMap`), just...

> the edge cases you have found seem to be edge cases where spigot doesnt even check for. does paper check for these?

> Just tested this on 1.20.1, there a few things that I found: > > 1. Snow golem will not spawn in any of the possible spawning rules (normal, upside...

Ready for another round of testing. Fixes the issues with inverted orientations and the use of soul sand. Also added more unit tests for the new cases. cc: @variananora for...

Noticed intellij has an error with `./gradlew clean build` if ran from within the IDE. Possible fixes have something to do with re-specifying the javaagent. Running it via CLI is...

I currently have the exact same issue as @tenent007963 I know this is somewhat (4 months) late. Has there been any updates to fix this issue? I have tried both...

I briefly looked into the commit history of the patch which adds this API on paper. Basically, the tags in `MaterialTags` are based on the `Material` enum. So the most...