Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

Convert to Gradle Kotlin DSL

Open md5sha256 opened this issue 1 year ago โ€ข 3 comments

Description

PoC of using Gradle as the buildscript

Proposed changes

Remove all maven buildscripts Use the gradle wrapper and the gradle Kotlin DSL for buildscripts Bumped minimum Java version to 17 due to dependency incompatibilities with Authlib being compiled against java 17.

Related Issues (if applicable)

Checklist

  • [ ] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [ ] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • [ ] I followed the existing code standards and didn't mess up the formatting.
  • [ ] I did my best to add documentation to any public classes or methods I added.
  • [ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • [ ] I added sufficient Unit Tests to cover my code.

md5sha256 avatar Apr 22 '24 06:04 md5sha256

Pro Tip! You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. โค๏ธ

Branch naming convention Label
feature/** ๐ŸŽˆ Feature
fix/** โœจ Fix
chore/** ๐Ÿงน Chores
api/** ๐Ÿ”ง API
performance/** ๐Ÿ’ก Performance Optimization
compatibility/** ๐Ÿค Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! ๐Ÿ‘€

github-actions[bot] avatar Apr 22 '24 06:04 github-actions[bot]

Slimefun preview build

A Slimefun preview build is available for testing! Commit: bfb6574f

https://preview-builds.walshy.dev/download/Slimefun/4175/bfb6574f

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

github-actions[bot] avatar Apr 22 '24 07:04 github-actions[bot]

Noticed intellij has an error with ./gradlew clean build if ran from within the IDE. Possible fixes have something to do with re-specifying the javaagent. Running it via CLI is fine though.

md5sha256 avatar Apr 22 '24 07:04 md5sha256