Andrew Wong
Andrew Wong
I'm still running into this. I should also specify that this breaks on both light and dark themes. Java Version: `openjdk version "15.0.1" 2020-10-20` JavaFX Version: `11.0.2` JMetro Version: `11.16.2`....
Have you tried asking intellij to re-import/resolve dependencies?
The singleton thing should now be resolved. I guess naming schemes and the long methods are left to fix. Would it be worthwhile splitting commands of each category into their...
Right, but say we split the commands into their own classes, should we register command contexts & completions by each command group, or everything in one place (or two, as...
Alright, I'll implement then mark dis as ready to review.
So basic benchmark: 3786 (omit because JIT?), 3233 (omit . . .), 1168, 1028, 1021 (10k schem pastes, with physics) 793, 766, 789, 1305, 807 (10k schem pastes without physics)...
Is unit testing the only thing missing on this PR or are there other issues to be resolved?
Just a note, I haven't completed a full test with Slimefun/addons however I've manually tested the core logic of parsing the removed blocks (So `implementation/utils/blockpattern/TShapedBlockPattern` and `implementation/utils/blockpattern/WitherBuildPattern`) on a dev-plugin...
> That's awesome! Good and clean solution to a very awkward problem, thank you! > > Does this also prevent the blocks from being removed or will it just cancel...
> I meaan the physical blocks, not the block storage data. Like, will this leave the structure behind or will it create ghost blocks and air nonetheless. This will leave...