Andrew Wong

Results 45 comments of Andrew Wong

Which locks are you referring to? The ones which lock the queues for copy + block storage stuff?

Ah yes so basically we lock some of the queues due to the underlying `Location` objects being mutable. I have a WIP thing which adds more detailed docs among others...

I can do another PR which just converts everything to block pos but from the last time I had a go at it my concern was that we'd just be...

Yes. The rewrite will help for anything that needs immutable locations. Its just a bit of a waste to have to keep converting to keep compatibility with API sometimes.

I'd like to request for `master` to be merged in once again

I think this can now be un-marked as a draft.

What... this compiled fine for me yesterday

Ok now that this compiles... can it be un-marked as a draft?

About thread interruption: I suppose we actually do need to re-interrupt the thread for `TickerTask#halt`. I misread something regarding re-throwing the exception or re-interrupting, sonarcloud is correct.