Andrew Wong comments

Results 45 comments of


                                            Andrew Wong

Add parameter validations to any public methods and enforce non-nullability

#41

Add Unit Tests for `CopyUtils.java`

Yes

Add Unit Tests for `CopyUtils.java`

I know right

[1.2.0] New inventory system

LGTM bar the comments left by Sfiguz. I'll approve once those are resolved I suppose

Enforce nullability in all modules

Merge conflicts should be fixed.

FIx dough-common and co being on the wrong scope in dough modules

Walshy mentioned that it was on the wrong scope. I'm not sure why so I guess I'll have to ping here and ask for the explanation. @WalshyDev

Robots can move outside island

What does this have to do with dough?

Robots can move outside island

Ah yes, I didn't see the original issue. Thanks.

Use a thread-safe Set impl for the TickerTask's tickingLocations

Haven't tested this on the server yet but I expect the chance of a major bug ocurring are unlikely.

Update to 1.20.5

Okay so tests now compiled on Java 21 (main sources still compile agains 16) and the mockbukkit version. I've also fixed the merge conflict so now all thats left for...