Michael Coker

Results 156 comments of Michael Coker

A side note, I was having problems with puppeteer on an m1 mac and found a solution, but noticed we're on 5.3.1 and looks like latest is 15.1.1 - https://www.npmjs.com/package/puppeteer?activeTab=versions

Once https://github.com/patternfly/patternfly/issues/5966 is complete, assuming those styles are pretty much a copy of the core `pf-[v]-c-content` (aka, react `` and ``) component, ideally, we should be able to yank out...

LGTM! I have a question below: One thing I look for is if we reference any CSS vars in the react component, and make sure whatever that's doing still works...

Core work is done here https://github.com/patternfly/patternfly/pull/6434 TL;DR * The parent component element (`.pf-v5-c-menu-toggle`) gets a status class (`.pf-m-success/warning/danger`) * Adds a new `.pf-v5-c-menu-toggle__icon` element that holds the status icon *...

labels touching the edge of the container Double blue border - the menu toggle's expanded styling and the focus ring on the inner text input. @andrew-ronaldson @lboehling wdyt, does this...

In chatting with @lboehling about it yesterday, she said that ideally there would be no background color applied to that toggle. We have a button variation that does that, but...

@nicolethoen Looking at this a bit more, the wizard main section (with overflow) isn't "`position`ed" (it uses the default `position: static`, or is unset actually), so we could just tweak...

@mattnolting just wanted to check on this one - do you want to keep this issue open? Gap and the option to switch between margin and gap has support. When...

Fixed in v5, these were updated to use our secondary text color.