patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard
verified publisher icon patternfly

Bug - Select - validated

Open dlabrecq opened this issue 1 year ago • 2 comments

The v4 Select supported a validated property; however, it has been omitted for v5. The design guidelines currently state the "Select component offers three validation-state presentations", but I don't see how the "validated selections" example is achieved in v5?

We've been using validation in Cost Management, but are blocked from updating to the v5 Select.

Cost Management snapshot Screenshot 2024-01-19 at 9 19 55 AM

dlabrecq avatar Jan 19 '24 14:01 dlabrecq

Related https://github.com/patternfly/patternfly/issues/6242

dlabrecq avatar Jan 19 '24 17:01 dlabrecq

Was also opened here at some point: https://github.com/patternfly/patternfly/issues/5917

rbertucat avatar Jan 22 '24 14:01 rbertucat

Core work is done here https://github.com/patternfly/patternfly/pull/6434

TL;DR

  • The parent component element (.pf-v5-c-menu-toggle) gets a status class (.pf-m-success/warning/danger)
  • Adds a new .pf-v5-c-menu-toggle__icon element that holds the status icon
    • This is rendered in .pf-v5-c-menu-toggle__controls, next to the caret icon
  • We may want to add something so screen readers announce the status - https://github.com/patternfly/patternfly/pull/6434#pullrequestreview-1946422952

mcoker avatar Mar 26 '24 19:03 mcoker