Consume core updates: Dual list selector ( Follow up to issue)

[tlabaj]

Follow up to core issue https://github.com/patternfly/patternfly/issues/5741

[kmcfaul]

No react changes required.

[kmcfaul]

@patternfly/design-reviewers @patternfly/core-in-react-reviewers

Could we get design+core eyes to ensure DualListSelector (current version) looks good on the react side?

[mcoker]

LGTM! I have a question below:

One thing I look for is if we reference any CSS vars in the react component, and make sure whatever that's doing still works as expected. I see we're importing a react-token to get the CSS var name for a menu's min-height, and setting that var here and here to the value of the prop listMinHeight. But I'm not sure how to test that prop 😅 Can someone validate that still works as expected?

[kmcfaul]

@mcoker The listMinHeight is only available in the composable DualListSelector example (because it's passed directly to the DualListSelectorPane), which the example sets both to "300px". If both panes have the prop set that will change the overall minimum height.

The --pf-v5-c-dual-list-selector__menu--MinHeight token is what is getting set by the prop.

[kmcfaul]

Just need design once-over @patternfly/design-reviewers