patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Consume tokens: Select

Open tlabaj opened this issue 1 year ago • 6 comments
trafficstars

Depends on https://github.com/patternfly/patternfly-react/issues/9985 and https://github.com/patternfly/patternfly-react/issues/9986

tlabaj avatar Jan 16 '24 22:01 tlabaj

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Mar 20 '24 04:03 stale[bot]

No react changes required.

cc @patternfly/design-reviewers @patternfly/core-in-react-reviewers to verify.

kmcfaul avatar Apr 08 '24 17:04 kmcfaul

Screenshot 2024-04-09 at 4 47 10 PM Noticing these rounded corners on typeahead selects

andrew-ronaldson avatar Apr 09 '24 19:04 andrew-ronaldson

labels touching the edge of the container Screenshot 2024-04-09 at 2 50 03 PM

Double blue border - the menu toggle's expanded styling and the focus ring on the inner text input. @andrew-ronaldson @lboehling wdyt, does this styling look ok or should we make some changes? Screenshot 2024-04-09 at 2 49 25 PM

I think these and @andrew-ronaldson's comment are core issues. Opened a core issue for these - https://github.com/patternfly/patternfly/issues/6536

React select LGTM!

mcoker avatar Apr 09 '24 20:04 mcoker

Do we need to leave this open to double check the core changes?

andrew-ronaldson avatar Apr 10 '24 13:04 andrew-ronaldson

I think we can leave it open for that, especially if the core changes need react followup.

kmcfaul avatar Apr 15 '24 15:04 kmcfaul

@andrew @kmcfaul can we close this one?

tlabaj avatar Jun 04 '24 18:06 tlabaj

I think this can be closed now

andrew-ronaldson avatar Jun 04 '24 19:06 andrew-ronaldson