Max Katz

Results 288 comments of Max Katz

@workgroupengineering seems like it's not failing anymore after https://github.com/AvaloniaUI/Avalonia/pull/9195 4 PRs in a row merged successfully

> The keyboard focus should not change while scrolling. The virtualization code should not recycle the element having the keyboard focus. Not sure how possible it is. I wonder, if...

Also, if ItemsRepeater and DataGrid have the same problem (probably have)

Yes, it seems we still have a problem with StyleInclude.

> I've seen often times in the past developers are told to just create their own custom Button style and use that instead. Yes. Snipped from one of my projects:...

> The HyperlinkButton could have a new NavigateUri property added (like UWP). If a NavigateUri is set, then the HyperlinkButton is pressed, that Uri would be opened in a platform-specific...

If this control will be more useful than "button with a style", I am good with it. Especially if most of the code can be reused from the Button control....

> There may be an issue on Web, if the api is async. Navigator only allows sharing if the action is spawned by a user gesture. Yes, but you still...

Stream based sharing API also aligns with our plans to have a fallback solution, when "save file picker" is not available on system (iOS and non-Chrome Browser). See `Task Export(FilePickerOptions...

Virtualization can't properly work with hardcoded control items instead of MVVM-like approach with item sources and templates. Setting "VirtualizationMode="None"" fixes the problem. AFAIK it also is not reproduced with ItemsRepeater,...