Max Katz

Results 288 comments of Max Katz

> InsertRange in AvaloniaList implementation calls NotifyAdd which invokes the _collectionChanged event with NotifyCollectionChangedAction.Add which is meant for single item changes. InsertRange should instead be calling with NotifyCollectionChangedAction.Reset instead which...

@kekekeks is airhack possible on macos/linux?

INotifyCollectionChanged doesn't make sense together with IReadOnlyList semantically. You can't change a readonly list.

Can't it be replaced with item template?

I don't think it is possible now. As a workaround you can create additional property in your viewmodel.

SelectedValuePath as it is in WPF won't be implemented. We need a reflection friendly solution. Alternatively, it's possible to implement SelectedValuePath as it is in WPF, but with requiring x:DataType,...

@kolbyd @HoneyTauOverTwo you can set RenderOptions.BitmapInterpolationMode property: ```xaml ``` It has quite confusing naming for enum values, because we copied Skia naming. https://github.com/AvaloniaUI/Avalonia/blob/d1afd3bb591c266015dcdecc9611148ca08c2ee4/src/Skia/Avalonia.Skia/SkiaSharpExtensions.cs#L16 https://github.com/AvaloniaUI/Avalonia/blob/4c77f1eb3d11308412b915a82460e4408ce360a0/src/Windows/Avalonia.Direct2D1/Media/Imaging/WicBitmapImpl.cs#L28

Personally I believe we should have them enabled. But most likely it should be enabled slowly project by project with limited number of warnings to avoid noise. Less important warnings...