Maurycy Markowski

Results 155 comments of Maurycy Markowski

Fix `Nullable<T>.ToString()`

Thanks @ranma42 !

Query: potential bug in null semantics VisitSqlBinary

I agree, there shouldn't be risk of functional errors (i.e. data corruption) but potential missed optimizations. I'm not too concerned about this, but filed an issue to track this "just...

Query: optimize query sql patterns like `(x || y) && !y` into `x && !y` when y is non-nullable

We could recognize the pattern (and similar ones?): ```cs (x || IsNull(y)) && IsNotNull(y) ``` and simplify it to ```cs x && IsNotNull(y) ``` here is the truth table (just...

Implement string.Trim with parameters on SQL Server

mysql has to deal with this syntax in some places, we could introduce a similar solution: https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/blob/master/src/EFCore.MySql/Query/Expressions/Internal/MySqlComplexFunctionArgumentExpression.cs

EF Core Issue: Incorrect Save Order with TPC Inheritance

I am unable to reproduce this. The repro code succeeds for me (no FK constraint violations are observed).

EF Core Issue: Incorrect Save Order with TPC Inheritance

thanks for clarification @luigi68 I'm able to reproduce this now. SaveChanges was wrapped in a transaction that was rolled back. I see constraint violations when the transaction was removed and...

Add logging infra to PineconeClient and Index.

@neon-sunset get well soon! I'm planning to take a look at `ReadOnlyMemory` improvement as well and can do that in parallel to this work, so no rush.

Enable indexer complex properties

When implementing this, see https://github.com/dotnet/efcore/pull/34858

Allow complex types in base types in TPC and unmapped base types in TPT

When trying to bind complex property we are looking for table mapping so that we know which table/columns to bind. However the table mapping is missing here - We build...

Too many columns selected for collection subquery

These extra column projections are used as identifiers, so we know how to bucket the results. Related issue: https://github.com/dotnet/efcore/issues/32329