efcore Implement string.Trim with parameters on SQL Server

We currently translate string.Trim only when no characters are specified (whitespace only), and implement it with LTRIM/RTRIM.

SQL Server 2017 introduced a more fully-featured TRIM function which can accept characters to trim. To maintain compatibility with older versions we can still use this only when non-whitespace characters are specified. Unfortunately no similar overloads exist for LTRIM/RTRIM (#22924).

Note that TRIM has a funky syntax (TRIM ( [ characters FROM ] string )), instead of just commas.

Oct 08 '20 12:10 roji

mysql has to deal with this syntax in some places, we could introduce a similar solution:

https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/blob/master/src/EFCore.MySql/Query/Expressions/Internal/MySqlComplexFunctionArgumentExpression.cs

Oct 08 '20 19:10 maumar

Yeah, I have one too :rofl: Finally SQL Server will join the exclusive clique....

Oct 08 '20 22:10 roji

I would like to know how you expect the new TRIM function with parameters to work. Could it be easily translated to something like LTRIM(RTRIM('MyString', 'CharsToTrim'), 'CharsToTrim'), or are you expecting to use the new TRIM ( [ characters FROM ] string ) syntax?

Jun 21 '24 16:06 abdielcs

We should definitely translate to the new SQL Server 2022 function, but the quirky syntax makes this a more difficult task. That goes beyond a beginner-level issue for sure.

Jun 22 '24 08:06 roji