Maurycy Markowski

Results 124 comments of Maurycy Markowski

Note: OData $skiptoken uses string.Compare when the token is string based, effectively blocking that feature on Cosmos

also add something about value converters how they use converter from the argument passed to the function (and that we just need to map it to the store type) -...

The way `db.People.Any(p => p.DateTime == dateTimeOffset))` gets to us is in the form of: `DbSet().Any(p => (DateTimeOffset)p.DateTime == __dateTimeOffset_0)` and we naively translate it to: ```sql SELECT CASE WHEN...

We decided that we will not accept this PR, sorry. The problem is that this approach doesn't work great for TPT/TPC. Entities are spread around several tables that we would...

@zbarnett Here is the example that illustrates the problem: ```cs [ConditionalFact] public void Query_filters_test() { using var ctx = new MyContext(); ctx.Database.EnsureDeleted(); ctx.Database.EnsureCreated(); var query = ctx.Entities.OfType().ToList(); } public class...

@zbarnett yes, if pruning works we would reconsider - this was the major problem we had with the change and we are not fundamentally opposed to it. Fair warning though,...

according to documentation for json_extract: ``` SQL datatype of the result is NULL for a JSON null, INTEGER or REAL for a JSON numeric value, an INTEGER zero for a...

I like having them separate. Test files are already large enough (e.g. gears of war is 8.5k lines of code), that we had to split some of the test suites....

Sounds good, I can probably be persuaded also. Let's talk in person and look at some code ;)

Binding_interceptors_are_used_by_queries Multiple_materialization_interceptors_can_be_used Intercept_query_materialization_for_empty_constructor