Maurycy Markowski

Results 155 comments of Maurycy Markowski

@attilah that issue has now been fixed - fix will be available in preview2 or is currently available in the daily build. See https://github.com/dotnet/efcore/issues/32939

I've re-tested the code the samples provided and things work fine on my end. @KeterSCP 's issue with var thisFails = context.MainModels .Where(mainModel => mainModel.JsonModel.InnerModels.Any(inner => inner.Id == 1)) .ToList();...

@dks07 @PatrikFomin the issue throws a generic exception so it's possible this is a different bug. Can you please file new issue and provide the repro code?

temporal tables feature is currently only supported for TPH (see https://github.com/dotnet/efcore/issues/26457 for more context). We should block this in migrations until support for TPT/TPC is added.

In `RelationalSqlTranslatingExpressionVisitor.TryRewriteStructuralTypeEquality` for json type comparison we use the same logic as for any other entity (i.e. compare their PK properties). Problem is, Post is a JSON collection, it has...

@oleg-varlamov on related note, currently we have a problem with JSON (collection) entities that define property named `Id`. Even when comparison problem is fixed, you might run into some errors....

> I don't necessarily disagree, but note that this starts to applies value equality semantics on owned entities, where we usually have identity/reference semantics (e.g. when assigning). It may start...

note: this also fails for non-json scenarios. We try to generate the following sql: query: ```cs var postToSearch = new Post() { Foo = 1, Title = "First" }; var...