Maurycy Markowski

Results 155 comments of Maurycy Markowski

Adding support for serverless, reacting to api changes, adding tests

@neon-sunset thanks for the review and code fixes! I have just pushed in the final set of changes, so from my perspective the PR should be good to go. Wrt...

Minor improvement of `SqlServerParameterBasedSqlProcessor.Optimize`

I'm always a bit scared when changing order of operations in the optimizer, but this one should be safe. Thanks @ranma42

Exception when `SELECT`ing `(x ? A : default(int?) >= B)`

related to https://github.com/dotnet/efcore/issues/31020

Remove invalid optimization of CASE-WHEN expressions

@ranma42 thanks for doing the work! For the tests, I would suggest to use NullSemantics model (`NullSemanticsQueryFixtureBase`, `NullSemanticsQueryTestBase`) rather than Northwind. Northwind is somewhat special in our tests, given it...

Remove invalid optimization of CASE-WHEN expressions

@ranma42 thank you for the contribution!

Invalid optimization of CASE-WHEN expressions

I also agree that the most valuable optimization is the compare one. I would not like to strip case just for the sake of doing it (i.e. `x OR (NOT(y)...

Invalid optimization of CASE-WHEN expressions

fixed by @ranma42

Query: Improve query test matrix

Initial work and infrastructure added in cb270316d63730ae669ca8b6b8fb16b2a2f6abc2 Verification will be added in the future - mutators can be in 2 modes: generating query and generating baseline. When ran with the...

Use XOR to translate some == and != expressions

Thanks again @ranma42 !

Simplify `COALESCE` based on the nullability of its arguments

> > I'll look into adding/updating tests before marking this as ready for review. Currently I am thinking of: > > Sounds great. Hopefully there are nullable alternatives in the...