Matt Lord

@rohit-nayak-ps I've addressed your review comments now and the tests are all green again. Please let me know what you think. Thanks!

This is related to: https://github.com/vitessio/vitess/issues/14932

The general issue still remains. That's what this https://github.com/vitessio/vitess/pull/14424 and the tracking issue it's part of are meant to address.

@beingnoble03 Please feel free to work on it. We keep assigning things like this to people and then nothing happens, which causes additional work and problems.

> With the stall detection enabled, I was a bit concerned that we were creating many goroutines, since we are creating one for every transaction? So I added some logging...

> A couple of thoughts here: > > * Can we perform the stall check around the query execute(s)? Or is there a good reason to have this separate handler-based...

> > * Instead of a tablet level flag, what do you think about adding a workflow option (in the new json object). That way we can allow it to...

> > * Instead of a tablet level flag, what do you think about adding a workflow option (in the new json object). That way we can allow it to...

@rohit-nayak-ps I could also just remove the transaction duration (stallHandler) part and stick with the simpler heartbeat based check. I do believe that will still be able to catch all...

> > @rohit-nayak-ps I could also just remove the transaction duration (stallHandler) part and stick with the simpler heartbeat based check. > > This might indeed be a good path...