Matt Lord

Results 130 comments of Matt Lord

Thank you for the additional info, @wiebeytec ! I'll have to do some investigating and testing (on `main`) then to see if I can come up with any explanation and...

I think I see the problem, shown with this patch here: ``` diff --git a/go/vt/vtctl/workflow/server.go b/go/vt/vtctl/workflow/server.go index 17b01736a7..1bac98f55c 100644 --- a/go/vt/vtctl/workflow/server.go +++ b/go/vt/vtctl/workflow/server.go @@ -1970,14 +1970,6 @@ func (s *Server)...

@wiebeytec was that a workflow that you also created with `vtctlclient`? I wonder if the underlying problem happened earlier on (not putting a denied table entry in place) and we...

Thank you again, @wiebeytec ! I see what the issue is and I've updated the PR description to reflect the changes that will be made: https://github.com/vitessio/vitess/pull/15977

> Will placing the table in the deny list be bypassed with the routing rules? Otherwise table access is blocked. The table should only be in the deny list on...

It seems to be working for me here: https://github.com/vitessio/vitess/pull/14967 Thank you! Now I have to figure out how the code coverage went DOWN with cross package testing enabled. 🙂 These...

@shlomi-noach I just created one: https://github.com/vitessio/vitess/issues/16023

> Thank you @mattlord! Now that release-20 has been cut, are we good to be able to merge this? IMO at least, yes. 🙂

Anyone is welcome to open a PR. I don't want to assign it to anyone before there's a PR because history has shown that the assignee often doesn't end up...

> @mattlord May I work on this issue if this is still open ? @anshikavashistha sure, nobody else is working on this AFAIK. If you open a preliminary PR then...