Matt Lord

Results 130 comments of Matt Lord

Nice work, @L3o-pold! Thank you for that. I'll start a discussion on this and continue the investigation. I will let you know when I have any updates.

> vtbackup_transform is failing consistently which is concerning, but I also see this test failing a bunch on `main` recently, so maybe it's a flake? `vtbackup_transform` has been VERY flaky...

> This looks good in principle. > What did you mean by the `goleak` library not being useful in e2e tests? Seems that it only tests the main command go...

Hi @derekperkins, > Messaging uses vstream under the hood, and we specifically want it to use a secondary index. Would this change impact how this executes? > > Query setup...

I feel that deprecating the flag would be setting the default to true and adding a deprecation warning in the CLI and docs while removal would be removing the code...

If we can easily piggy back on an existing test, then I think it's worth adding one. You can manually repeat the issue on **_main_** this way from the base...

> @mattlord Have you been able to reproduce this issue locally. I have been trying for a while, but I can't seem to get it to fail on main even...

> Thinking about it further, if we don't have any writes in progress at the time we are trying to set read only, then how did it block at all?...

@derekperkins can you please verify that it's not just constantly restarting and retrying? One of the main reasons why we capped the retry period when seeing the same error over...

@derekperkins is this still an issue for you? I was going through existing issues and trying to clean things up. I'm wondering if in this case the materialization was in...