Matt Lord
Matt Lord
Note that this will not be a breaking change for the PlanetScale Airbyte connector as it will return the value as-is when it's not an integer: https://github.com/planetscale/airbyte-source/blob/426bcdb0b34c2f26276dbfe473f1f8b5627c2344/cmd/internal/types.go#L184-L236 The same is...
Related to: https://github.com/vitessio/vitess/issues/13960
@DeathBorn to be clear, [`vtctl` and `vtctlclient` have both been deprecated since v18](https://vitess.io/blog/2023-11-07-announcing-vitess-18/#vtctldclient) and we've been [talking about this since v14](https://vitess.io/docs/archive/14.0/reference/vtctldclient-transition/overview/). [`vtctldclient`](https://vitess.io/docs/reference/programs/vtctldclient/) uses the [`vtctlservice` `vtctld` RPCs](https://github.com/vitessio/vitess/blob/main/proto/vtctlservice.proto) that you can...
In looking at this: - https://github.com/vitessio/vitess/blob/1fd6d904ed1994a91f0901704f15123a292ef205/proto/vtctldata.proto#L1031-L1034 - https://vitess.io/docs/reference/programs/vtctldclient/vtctldclient_gettablets/#options It seems to me that by default (`--strict=false`) we should _already_ be showing partial results. That would make this more obviously a...
So far, the new tests have confirmed that we do actually show partial results by default: https://github.com/vitessio/vitess/pull/15829 I'll add some additional ones but assuming they all confirm that we're already...
@DeathBorn a related aside/FYI, in v19+ the "new vtctl" is `vtctldclient --server internal`: https://github.com/vitessio/vitess/pull/14315 https://vitess.io/docs/19.0/reference/programs/vtctldclient/#synopsis You'll then have a `vtctldclient` process that uses a bundled/internal `VtctldServer` implementation and no external...
@DeathBorn I don't think I understand. Perhaps you're not including it in the `--service_map` flag for the `vtctld` instance? Like this: ``` vtctld ... --service_map 'grpc-vtctl,grpc-vtctld' ... ```
@DeathBorn Here's an example usage: ``` ❯ grpcurl -plaintext -format json -import-path ${VTROOT}/proto -proto vtctlservice.proto \ -d '{"keyspace":"commerce", "shard":"0", "tablet_type":"PRIMARY"}' \ localhost:15999 vtctlservice.Vtctld/GetTablets { "tablets": [ { "alias": { "cell":...
> Nice! Should we also provide the flag in `yaml` files? Yeah. I *think* this does it. https://github.com/planetscale/vitess-operator/pull/541/commits/e2e5e8b1e749b6f550ee72e77dce2f8ef326408d
> How is the value being set, and to what specific value? The user would specify the flag and value in their cluster yaml definition using the `extraFlags` parameter, just...