vitess icon indicating copy to clipboard operation
vitess copied to clipboard

Published 20 hours ago • verified publisher icon vitessio

Improve Unit Test Coverage

Open GuptaManan100 opened this issue 1 year ago • 10 comments

Description

The unit test coverage of all the packages in Vitess need to be checked and improved upon. We can look at https://app.codecov.io/gh/vitessio/vitess/tree/main for better guidance on which packages require testing.

List of all the packages in Vitess -

  • [ ] vitess/go
    • [x] vitess/go/acl https://github.com/vitessio/vitess/pull/14943
    • [x] vitess/go/atomic2: https://github.com/vitessio/vitess/pull/14975
    • [x] vitess/go/bucketpool https://github.com/vitessio/vitess/pull/14944
    • [x] vitess/go/bytes2
      • https://github.com/vitessio/vitess/pull/14958
      • https://github.com/vitessio/vitess/pull/14940
    • [ ] vitess/go/cache
      • [ ] vitess/go/cache/theine
        • [ ] vitess/go/cache/theine/bf
    • [x] vitess/go/cmd
      • [ ] vitess/go/cmd/internal
        • [ ] vitess/go/cmd/internal/docgen
      • [ ] vitess/go/cmd/mysqlctl
        • [ ] vitess/go/cmd/mysqlctl/command
        • [ ] vitess/go/cmd/mysqlctl/docgen
      • [ ] vitess/go/cmd/mysqlctld
        • [ ] vitess/go/cmd/mysqlctld/cli
        • [ ] vitess/go/cmd/mysqlctld/docgen
      • [ ] vitess/go/cmd/rulesctl
        • [ ] vitess/go/cmd/rulesctl/cmd
        • [ ] vitess/go/cmd/rulesctl/common
      • [ ] vitess/go/cmd/topo2topo
        • [ ] vitess/go/cmd/topo2topo/cli
        • [ ] vitess/go/cmd/topo2topo/docgen
      • [ ] vitess/go/cmd/vtaclcheck
        • [ ] vitess/go/cmd/vtaclcheck/cli
        • [ ] vitess/go/cmd/vtaclcheck/docgen
      • [ ] vitess/go/cmd/vtadmin
      • [ ] vitess/go/cmd/vtbackup
        • [ ] vitess/go/cmd/vtbackup/cli
        • [ ] vitess/go/cmd/vtbackup/docgen
      • [ ] vitess/go/cmd/vtbench
        • [ ] vitess/go/cmd/vtbench/cli
        • [ ] vitess/go/cmd/vtbench/docgen
      • [ ] vitess/go/cmd/vtclient
        • [ ] vitess/go/cmd/vtclient/cli
        • [ ] vitess/go/cmd/vtclient/docgen
      • [ ] vitess/go/cmd/vtcombo
        • [ ] vitess/go/cmd/vtcombo/cli
        • [ ] vitess/go/cmd/vtcombo/docgen
      • [ ] vitess/go/cmd/vtctl
      • [ ] vitess/go/cmd/vtctlclient
      • [ ] vitess/go/cmd/vtctld
        • [ ] vitess/go/cmd/vtctld/cli
        • [ ] vitess/go/cmd/vtctld/docgen
      • [ ] vitess/go/cmd/vtctldclient
        • [ ] vitess/go/cmd/vtctldclient/cli
        • [ ] vitess/go/cmd/vtctldclient/command
          • [ ] vitess/go/cmd/vtctldclient/command/vreplication
            • [ ] vitess/go/cmd/vtctldclient/command/vreplication/common
            • [ ] vitess/go/cmd/vtctldclient/command/vreplication/lookupvindex
            • [ ] vitess/go/cmd/vtctldclient/command/vreplication/materialize
            • [ ] vitess/go/cmd/vtctldclient/command/vreplication/migrate
            • [ ] vitess/go/cmd/vtctldclient/command/vreplication/mount
            • [ ] vitess/go/cmd/vtctldclient/command/vreplication/movetables
            • [ ] vitess/go/cmd/vtctldclient/command/vreplication/reshard
            • [ ] vitess/go/cmd/vtctldclient/command/vreplication/vdiff
            • [ ] vitess/go/cmd/vtctldclient/command/vreplication/workflow
        • [ ] vitess/go/cmd/vtctldclient/docgen
      • [ ] vitess/go/cmd/vtexplain
        • [ ] vitess/go/cmd/vtexplain/cli
        • [ ] vitess/go/cmd/vtexplain/docgen
      • [ ] vitess/go/cmd/vtgate
        • [ ] vitess/go/cmd/vtgate/cli
        • [ ] vitess/go/cmd/vtgate/docgen
      • [ ] vitess/go/cmd/vtgateclienttest
        • [ ] vitess/go/cmd/vtgateclienttest/cli
        • [ ] vitess/go/cmd/vtgateclienttest/docgen
        • [ ] vitess/go/cmd/vtgateclienttest/services
      • [ ] vitess/go/cmd/vtorc
        • [ ] vitess/go/cmd/vtorc/cli
        • [ ] vitess/go/cmd/vtorc/docgen
      • [ ] vitess/go/cmd/vttablet
        • [ ] vitess/go/cmd/vttablet/cli
        • [ ] vitess/go/cmd/vttablet/docgen
      • [ ] vitess/go/cmd/vttestserver
        • [ ] vitess/go/cmd/vttestserver/cli
          • [x] vitess/go/cmd/vttestserver/cli/data
            • [x] vitess/go/cmd/vttestserver/cli/data/schema
              • [x] vitess/go/cmd/vttestserver/cli/data/schema/app_customer
              • [x] vitess/go/cmd/vttestserver/cli/data/schema/test_keyspace
        • [ ] vitess/go/cmd/vttestserver/docgen
      • [ ] vitess/go/cmd/vttlstest
        • [ ] vitess/go/cmd/vttlstest/cli
        • [ ] vitess/go/cmd/vttlstest/docgen
      • [ ] vitess/go/cmd/zk
        • [ ] vitess/go/cmd/zk/command
        • [ ] vitess/go/cmd/zk/docgen
        • [ ] vitess/go/cmd/zk/internal
          • [x] vitess/go/cmd/zk/internal/zkfilepath: https://github.com/vitessio/vitess/pull/14970
          • [ ] vitess/go/cmd/zk/internal/zkfs
      • [ ] vitess/go/cmd/zkctl
        • [ ] vitess/go/cmd/zkctl/command
        • [ ] vitess/go/cmd/zkctl/docgen
      • [ ] vitess/go/cmd/zkctld
        • [ ] vitess/go/cmd/zkctld/cli
        • [ ] vitess/go/cmd/zkctld/docgen
    • [x] vitess/go/constants
      • [ ] vitess/go/constants/sidecar
    • [x] vitess/go/errors
    • [x] vitess/go/event
      • [x] vitess/go/event/syslogger
        • https://github.com/vitessio/vitess/pull/14942
    • [x] vitess/go/exit
    • [x] vitess/go/fileutil
    • [x] vitess/go/flags
      • [x] vitess/go/flags/endtoend
    • [x] vitess/go/flagutil
    • [ ] vitess/go/hack
    • [x] vitess/go/history
    • [x] vitess/go/internal
      • [x] vitess/go/internal/flag
    • [ ] vitess/go/ioutil
    • [x] vitess/go/json2 https://github.com/vitessio/vitess/pull/14964
    • [x] vitess/go/jsonutil
    • [x] vitess/go/list
    • [ ] vitess/go/logstats
    • [ ] vitess/go/mathstats
    • [x] vitess/go/mathutil: https://github.com/vitessio/vitess/pull/14969
    • [ ] vitess/go/mysql
      • [ ] vitess/go/mysql/binlog
      • [ ] vitess/go/mysql/capabilities
      • [ ] vitess/go/mysql/collations
        • [ ] vitess/go/mysql/collations/charset
          • [ ] vitess/go/mysql/collations/charset/eightbit
          • [ ] vitess/go/mysql/collations/charset/japanese
          • [ ] vitess/go/mysql/collations/charset/korean
          • [ ] vitess/go/mysql/collations/charset/simplifiedchinese
          • [ ] vitess/go/mysql/collations/charset/testdata
          • [ ] vitess/go/mysql/collations/charset/types
          • [ ] vitess/go/mysql/collations/charset/unicode
        • [ ] vitess/go/mysql/collations/colldata
        • [ ] vitess/go/mysql/collations/integration
          • [x] vitess/go/mysql/collations/integration/testdata
            • [x] vitess/go/mysql/collations/integration/testdata/mysqltest
              • [x] vitess/go/mysql/collations/integration/testdata/mysqltest/suite
                • [x] vitess/go/mysql/collations/integration/testdata/mysqltest/suite/collations
                  • [x] vitess/go/mysql/collations/integration/testdata/mysqltest/suite/collations/include
        • [ ] vitess/go/mysql/collations/internal
          • [ ] vitess/go/mysql/collations/internal/uca
        • [ ] vitess/go/mysql/collations/remote
        • [x] vitess/go/mysql/collations/testdata
          • [x] vitess/go/mysql/collations/testdata/mysqldata
          • [x] vitess/go/mysql/collations/testdata/versions
        • [ ] vitess/go/mysql/collations/testutil
        • [ ] vitess/go/mysql/collations/tools
          • [ ] vitess/go/mysql/collations/tools/colldump
          • [ ] vitess/go/mysql/collations/tools/makecolldata
            • [ ] vitess/go/mysql/collations/tools/makecolldata/codegen
          • [ ] vitess/go/mysql/collations/tools/maketestdata
        • [ ] vitess/go/mysql/collations/vindex
          • [ ] vitess/go/mysql/collations/vindex/collate
          • [ ] vitess/go/mysql/collations/vindex/internal
            • [ ] vitess/go/mysql/collations/vindex/internal/colltab
          • [ ] vitess/go/mysql/collations/vindex/unicode
            • [ ] vitess/go/mysql/collations/vindex/unicode/norm
      • [ ] vitess/go/mysql/config
      • [ ] vitess/go/mysql/datetime
        • [x] vitess/go/mysql/datetime/testdata
      • [ ] vitess/go/mysql/decimal
        • [x] vitess/go/mysql/decimal/testdata
      • [x] vitess/go/mysql/endtoend
      • [x] vitess/go/mysql/fakesqldb
      • [x] vitess/go/mysql/fastparse
      • [x] vitess/go/mysql/format
      • [x] vitess/go/mysql/fuzzdata
      • [x] vitess/go/mysql/hex: https://github.com/vitessio/vitess/pull/14976
      • [ ] vitess/go/mysql/icuregex
        • [ ] vitess/go/mysql/icuregex/errors
        • [ ] vitess/go/mysql/icuregex/internal
          • [ ] vitess/go/mysql/icuregex/internal/bytestrie
          • [ ] vitess/go/mysql/icuregex/internal/icudata
          • [ ] vitess/go/mysql/icuregex/internal/normalizer
          • [ ] vitess/go/mysql/icuregex/internal/pattern
          • [ ] vitess/go/mysql/icuregex/internal/ubidi
          • [ ] vitess/go/mysql/icuregex/internal/ucase
          • [ ] vitess/go/mysql/icuregex/internal/uchar
          • [ ] vitess/go/mysql/icuregex/internal/udata
          • [ ] vitess/go/mysql/icuregex/internal/uemoji
          • [ ] vitess/go/mysql/icuregex/internal/ulayout
          • [ ] vitess/go/mysql/icuregex/internal/unames
          • [ ] vitess/go/mysql/icuregex/internal/uprops
          • [ ] vitess/go/mysql/icuregex/internal/uset
          • [ ] vitess/go/mysql/icuregex/internal/utf16
          • [ ] vitess/go/mysql/icuregex/internal/utrie
        • [x] vitess/go/mysql/icuregex/testdata
      • [ ] vitess/go/mysql/json
      • [ ] vitess/go/mysql/ldapauthserver
      • [ ] vitess/go/mysql/replication
      • [ ] vitess/go/mysql/sqlerror
      • [ ] vitess/go/mysql/vault
    • [ ] vitess/go/netutil
    • [ ] vitess/go/pools
      • [ ] vitess/go/pools/smartconnpool
        • [x] vitess/go/pools/smartconnpool/benchmarking
          • [x] vitess/go/pools/smartconnpool/benchmarking/legacy
    • [x] vitess/go/protoutil https://github.com/vitessio/vitess/pull/14965
    • [x] vitess/go/race
    • [x] vitess/go/sets: https://github.com/vitessio/vitess/pull/14973
    • [x] vitess/go/slice
    • [x] vitess/go/sqlescape: https://github.com/vitessio/vitess/pull/14987
    • [ ] vitess/go/sqltypes
    • [ ] vitess/go/stats
      • [ ] vitess/go/stats/opentsdb
      • [ ] vitess/go/stats/prometheusbackend
      • [ ] vitess/go/stats/statsd
    • [ ] vitess/go/streamlog
    • [ ] vitess/go/sync2
    • [ ] vitess/go/syscallutil
    • [x] vitess/go/tb
    • [x] vitess/go/testfiles
    • [x] vitess/go/textutil
    • [ ] vitess/go/timer
    • [ ] vitess/go/tools
      • [ ] vitess/go/tools/astfmtgen
      • [ ] vitess/go/tools/asthelpergen
        • [ ] vitess/go/tools/asthelpergen/integration
        • [ ] vitess/go/tools/asthelpergen/main
      • [ ] vitess/go/tools/ci-config
      • [ ] vitess/go/tools/codegen
      • [ ] vitess/go/tools/go-upgrade
      • [ ] vitess/go/tools/graphviz
      • [ ] vitess/go/tools/release-notes
        • [ ] vitess/go/tools/release-notes/integration
      • [ ] vitess/go/tools/releases
      • [ ] vitess/go/tools/sizegen
        • [ ] vitess/go/tools/sizegen/integration
    • [ ] vitess/go/trace
    • [x] vitess/go/unicode2
    • [ ] vitess/go/viperutil
      • [ ] vitess/go/viperutil/debug
      • [ ] vitess/go/viperutil/funcs
      • [ ] vitess/go/viperutil/internal
        • [ ] vitess/go/viperutil/internal/log
        • [ ] vitess/go/viperutil/internal/registry
        • [ ] vitess/go/viperutil/internal/sync
        • [ ] vitess/go/viperutil/internal/value
      • [ ] vitess/go/viperutil/vipertest
    • [ ] vitess/go/vt
      • [ ] vitess/go/vt/binlog
        • [ ] vitess/go/vt/binlog/binlogplayer
        • [ ] vitess/go/vt/binlog/binlogplayertest
        • [ ] vitess/go/vt/binlog/eventtoken
        • [ ] vitess/go/vt/binlog/grpcbinlogplayer
        • [ ] vitess/go/vt/binlog/grpcbinlogstreamer
      • [ ] vitess/go/vt/callerid
        • [x] vitess/go/vt/callerid/testsuite
      • [ ] vitess/go/vt/callinfo
        • [x] vitess/go/vt/callinfo/fakecallinfo
      • [ ] vitess/go/vt/concurrency
      • [ ] vitess/go/vt/dbconfigs
      • [ ] vitess/go/vt/dbconnpool
      • [ ] vitess/go/vt/discovery
      • [ ] vitess/go/vt/dtids
      • [ ] vitess/go/vt/env
      • [ ] vitess/go/vt/events
      • [ ] vitess/go/vt/external
        • [ ] vitess/go/vt/external/golib
          • [ ] vitess/go/vt/external/golib/sqlutils
      • [x] vitess/go/vt/graph
      • [ ] vitess/go/vt/grpcclient
      • [ ] vitess/go/vt/grpccommon
      • [ ] vitess/go/vt/grpcoptionaltls
      • [ ] vitess/go/vt/hook
      • [ ] vitess/go/vt/key
      • [ ] vitess/go/vt/log
      • [ ] vitess/go/vt/logutil
      • [ ] vitess/go/vt/logz
      • [x] vitess/go/vt/mysqlctl
        • [ ] vitess/go/vt/mysqlctl/azblobbackupstorage
        • [ ] vitess/go/vt/mysqlctl/backupstats
        • [ ] vitess/go/vt/mysqlctl/backupstorage
        • [ ] vitess/go/vt/mysqlctl/cephbackupstorage
        • [ ] vitess/go/vt/mysqlctl/filebackupstorage
        • [ ] vitess/go/vt/mysqlctl/gcsbackupstorage
        • [ ] vitess/go/vt/mysqlctl/grpcmysqlctlclient
        • [ ] vitess/go/vt/mysqlctl/grpcmysqlctlserver
        • [ ] vitess/go/vt/mysqlctl/mysqlctlclient
        • [ ] vitess/go/vt/mysqlctl/mysqlctlproto
        • [ ] vitess/go/vt/mysqlctl/s3backupstorage
        • [x] vitess/go/vt/mysqlctl/testdata
        • [ ] vitess/go/vt/mysqlctl/tmutils
      • [ ] vitess/go/vt/proto
        • [ ] vitess/go/vt/proto/binlogdata
        • [ ] vitess/go/vt/proto/binlogservice
        • [ ] vitess/go/vt/proto/logutil
        • [ ] vitess/go/vt/proto/mysqlctl
        • [ ] vitess/go/vt/proto/query
        • [ ] vitess/go/vt/proto/queryservice
        • [ ] vitess/go/vt/proto/replicationdata
        • [ ] vitess/go/vt/proto/tableacl
        • [ ] vitess/go/vt/proto/tabletmanagerdata
        • [ ] vitess/go/vt/proto/tabletmanagerservice
        • [ ] vitess/go/vt/proto/throttlerdata
        • [ ] vitess/go/vt/proto/throttlerservice
        • [ ] vitess/go/vt/proto/topodata
        • [ ] vitess/go/vt/proto/vschema
        • [ ] vitess/go/vt/proto/vtadmin
        • [ ] vitess/go/vt/proto/vtctldata
        • [ ] vitess/go/vt/proto/vtctlservice
        • [ ] vitess/go/vt/proto/vtgate
        • [ ] vitess/go/vt/proto/vtgateservice
        • [ ] vitess/go/vt/proto/vtrpc
        • [ ] vitess/go/vt/proto/vttest
        • [ ] vitess/go/vt/proto/vttime
        • [ ] vitess/go/vt/proto/workflow
      • [ ] vitess/go/vt/schema
      • [ ] vitess/go/vt/schemadiff
      • [ ] vitess/go/vt/schemamanager
      • [ ] vitess/go/vt/servenv
        • [ ] vitess/go/vt/servenv/internal
          • [ ] vitess/go/vt/servenv/internal/mux
        • [x] vitess/go/vt/servenv/testutils
      • [ ] vitess/go/vt/sidecardb
        • [x] vitess/go/vt/sidecardb/schema
          • [x] vitess/go/vt/sidecardb/schema/misc
          • [x] vitess/go/vt/sidecardb/schema/onlineddl
          • [x] vitess/go/vt/sidecardb/schema/schemaengine
          • [x] vitess/go/vt/sidecardb/schema/schematracker
          • [x] vitess/go/vt/sidecardb/schema/twopc
          • [x] vitess/go/vt/sidecardb/schema/vdiff
          • [x] vitess/go/vt/sidecardb/schema/vreplication
      • [ ] vitess/go/vt/sqlparser
        • [ ] vitess/go/vt/sqlparser/goyacc
        • [ ] vitess/go/vt/sqlparser/optimizerhint
        • [x] vitess/go/vt/sqlparser/testdata
      • [ ] vitess/go/vt/srvtopo
        • [x] vitess/go/vt/srvtopo/srvtopotest
      • [ ] vitess/go/vt/sysvars
      • [ ] vitess/go/vt/tableacl
        • [ ] vitess/go/vt/tableacl/acl
        • [ ] vitess/go/vt/tableacl/simpleacl
        • [ ] vitess/go/vt/tableacl/testlib
      • [ ] vitess/go/vt/throttler
        • [x] vitess/go/vt/throttler/demo
        • [ ] vitess/go/vt/throttler/grpcthrottlerserver
      • [ ] vitess/go/vt/tlstest
      • [ ] vitess/go/vt/topo
        • [ ] vitess/go/vt/topo/consultopo
        • [ ] vitess/go/vt/topo/etcd2topo
        • [ ] vitess/go/vt/topo/events
        • [x] vitess/go/vt/topo/faketopo
        • [ ] vitess/go/vt/topo/helpers
        • [ ] vitess/go/vt/topo/memorytopo
        • [x] vitess/go/vt/topo/test
        • [ ] vitess/go/vt/topo/topoproto
        • [ ] vitess/go/vt/topo/topotests
        • [ ] vitess/go/vt/topo/zk2topo
      • [ ] vitess/go/vt/topotools
        • [ ] vitess/go/vt/topotools/events
      • [ ] vitess/go/vt/vitessdriver
      • [ ] vitess/go/vt/vtaclcheck
      • [ ] vitess/go/vt/vtadmin
        • [ ] vitess/go/vt/vtadmin/cache
        • [ ] vitess/go/vt/vtadmin/cluster
          • [ ] vitess/go/vt/vtadmin/cluster/discovery
            • [x] vitess/go/vt/vtadmin/cluster/discovery/fakediscovery
          • [ ] vitess/go/vt/vtadmin/cluster/dynamic
          • [ ] vitess/go/vt/vtadmin/cluster/internal
            • [ ] vitess/go/vt/vtadmin/cluster/internal/caches
              • [ ] vitess/go/vt/vtadmin/cluster/internal/caches/schemacache
          • [ ] vitess/go/vt/vtadmin/cluster/resolver
        • [ ] vitess/go/vt/vtadmin/credentials
        • [ ] vitess/go/vt/vtadmin/debug
        • [ ] vitess/go/vt/vtadmin/errors
        • [ ] vitess/go/vt/vtadmin/grpcserver
        • [ ] vitess/go/vt/vtadmin/http
          • [ ] vitess/go/vt/vtadmin/http/debug
          • [ ] vitess/go/vt/vtadmin/http/experimental
          • [ ] vitess/go/vt/vtadmin/http/handlers
        • [ ] vitess/go/vt/vtadmin/internal
          • [ ] vitess/go/vt/vtadmin/internal/backoff
          • [ ] vitess/go/vt/vtadmin/internal/rand
        • [ ] vitess/go/vt/vtadmin/rbac
          • [ ] vitess/go/vt/vtadmin/rbac/example
        • [ ] vitess/go/vt/vtadmin/sort
        • [ ] vitess/go/vt/vtadmin/testutil
          • [ ] vitess/go/vt/vtadmin/testutil/authztestgen
        • [ ] vitess/go/vt/vtadmin/vtadminproto
        • [ ] vitess/go/vt/vtadmin/vtctldclient
          • [ ] vitess/go/vt/vtadmin/vtctldclient/fakevtctldclient
        • [ ] vitess/go/vt/vtadmin/vtsql
          • [ ] vitess/go/vt/vtadmin/vtsql/fakevtsql
      • [ ] vitess/go/vt/vtcombo
      • [ ] vitess/go/vt/vtctl
        • [x] vitess/go/vt/vtctl/endtoend
        • [ ] vitess/go/vt/vtctl/grpcclientcommon
        • [ ] vitess/go/vt/vtctl/grpcvtctlclient
        • [ ] vitess/go/vt/vtctl/grpcvtctldclient
        • [ ] vitess/go/vt/vtctl/grpcvtctldserver
          • [x] vitess/go/vt/vtctl/grpcvtctldserver/endtoend
          • [x] vitess/go/vt/vtctl/grpcvtctldserver/testutil
        • [ ] vitess/go/vt/vtctl/grpcvtctlserver
        • [ ] vitess/go/vt/vtctl/internal
          • [ ] vitess/go/vt/vtctl/internal/grpcshim
        • [ ] vitess/go/vt/vtctl/localvtctldclient
        • [ ] vitess/go/vt/vtctl/reparentutil
          • [ ] vitess/go/vt/vtctl/reparentutil/promotionrule
          • [ ] vitess/go/vt/vtctl/reparentutil/reparenttestutil
        • [ ] vitess/go/vt/vtctl/schematools
        • [ ] vitess/go/vt/vtctl/testdata
        • [ ] vitess/go/vt/vtctl/vtctlclient
        • [ ] vitess/go/vt/vtctl/vtctlclienttest
        • [ ] vitess/go/vt/vtctl/vtctldclient
          • [ ] vitess/go/vt/vtctl/vtctldclient/codegen
        • [ ] vitess/go/vt/vtctl/workflow
          • [ ] vitess/go/vt/vtctl/workflow/common
          • [ ] vitess/go/vt/vtctl/workflow/vexec
            • [ ] vitess/go/vt/vtctl/workflow/vexec/testutil
      • [ ] vitess/go/vt/vtctld
      • [ ] vitess/go/vt/vterrors
        • [ ] vitess/go/vt/vterrors/vterrorsgen
      • [ ] vitess/go/vt/vtexplain
        • [x] vitess/go/vt/vtexplain/testdata
          • [x] vitess/go/vt/vtexplain/testdata/multi-output
          • [x] vitess/go/vt/vtexplain/testdata/twopc-output
      • [ ] vitess/go/vt/vtgate
        • [ ] vitess/go/vt/vtgate/buffer
        • [x] vitess/go/vt/vtgate/endtoend
          • [x] vitess/go/vt/vtgate/endtoend/deletetest
          • [x] vitess/go/vt/vtgate/endtoend/update
        • [ ] vitess/go/vt/vtgate/engine
          • [ ] vitess/go/vt/vtgate/engine/opcode
        • [ ] vitess/go/vt/vtgate/errorsanitizer
        • [ ] vitess/go/vt/vtgate/evalengine
          • [ ] vitess/go/vt/vtgate/evalengine/integration
            • [x] vitess/go/vt/vtgate/evalengine/integration/testdata
          • [x] vitess/go/vt/vtgate/evalengine/testcases
        • [x] vitess/go/vt/vtgate/fakerpcvtgateconn
        • [ ] vitess/go/vt/vtgate/grpcvtgateconn
        • [ ] vitess/go/vt/vtgate/grpcvtgateservice
        • [ ] vitess/go/vt/vtgate/logstats
        • [ ] vitess/go/vt/vtgate/planbuilder
          • [ ] vitess/go/vt/vtgate/planbuilder/operators
            • [x] vitess/go/vt/vtgate/planbuilder/operators/fuzzdata
          • [ ] vitess/go/vt/vtgate/planbuilder/plancontext
          • [x] vitess/go/vt/vtgate/planbuilder/testdata
            • [x] vitess/go/vt/vtgate/planbuilder/testdata/vschemas
        • [ ] vitess/go/vt/vtgate/schema
        • [ ] vitess/go/vt/vtgate/semantics
          • [ ] vitess/go/vt/vtgate/semantics/bitset
        • [ ] vitess/go/vt/vtgate/simplifier
        • [x] vitess/go/vt/vtgate/testdata
        • [ ] vitess/go/vt/vtgate/vindexes
          • [x] vitess/go/vt/vtgate/vindexes/testdata
        • [ ] vitess/go/vt/vtgate/vschemaacl
        • [ ] vitess/go/vt/vtgate/vtgateconn
        • [ ] vitess/go/vt/vtgate/vtgateservice
      • [ ] vitess/go/vt/vthash
        • [ ] vitess/go/vt/vthash/highway
        • [ ] vitess/go/vt/vthash/metro
      • [ ] vitess/go/vt/vtorc
        • [ ] vitess/go/vt/vtorc/collection
        • [ ] vitess/go/vt/vtorc/config
        • [ ] vitess/go/vt/vtorc/db
        • [ ] vitess/go/vt/vtorc/discovery
        • [ ] vitess/go/vt/vtorc/inst
        • [ ] vitess/go/vt/vtorc/logic
        • [ ] vitess/go/vt/vtorc/metrics
          • [ ] vitess/go/vt/vtorc/metrics/query
        • [ ] vitess/go/vt/vtorc/process
        • [ ] vitess/go/vt/vtorc/server
        • [x] vitess/go/vt/vtorc/test
        • [ ] vitess/go/vt/vtorc/util
      • [ ] vitess/go/vt/vttablet
        • [ ] vitess/go/vt/vttablet/customrule
          • [ ] vitess/go/vt/vttablet/customrule/filecustomrule
          • [ ] vitess/go/vt/vttablet/customrule/topocustomrule
        • [x] vitess/go/vt/vttablet/endtoend
          • [x] vitess/go/vt/vttablet/endtoend/connkilling
          • [x] vitess/go/vt/vttablet/endtoend/framework
          • [x] vitess/go/vt/vttablet/endtoend/streamtimeout
        • [x] vitess/go/vt/vttablet/faketmclient
        • [ ] vitess/go/vt/vttablet/filelogger
        • [ ] vitess/go/vt/vttablet/grpcqueryservice
        • [ ] vitess/go/vt/vttablet/grpctabletconn
        • [ ] vitess/go/vt/vttablet/grpctmclient
        • [ ] vitess/go/vt/vttablet/grpctmserver
        • [ ] vitess/go/vt/vttablet/onlineddl
          • [ ] vitess/go/vt/vttablet/onlineddl/vrepl
        • [ ] vitess/go/vt/vttablet/queryservice
          • [x] vitess/go/vt/vttablet/queryservice/fakes
        • [ ] vitess/go/vt/vttablet/sandboxconn
        • [ ] vitess/go/vt/vttablet/sysloglogger
        • [ ] vitess/go/vt/vttablet/tabletconn
        • [x] vitess/go/vt/vttablet/tabletconntest
        • [ ] vitess/go/vt/vttablet/tabletmanager
          • [ ] vitess/go/vt/vttablet/tabletmanager/events
          • [ ] vitess/go/vt/vttablet/tabletmanager/vdiff
          • [ ] vitess/go/vt/vttablet/tabletmanager/vreplication
            • [ ] vitess/go/vt/vttablet/tabletmanager/vreplication/queryhistory
        • [ ] vitess/go/vt/vttablet/tabletserver
          • [ ] vitess/go/vt/vttablet/tabletserver/connpool
          • [ ] vitess/go/vt/vttablet/tabletserver/gc
          • [ ] vitess/go/vt/vttablet/tabletserver/heartbeat
          • [ ] vitess/go/vt/vttablet/tabletserver/messager
          • [ ] vitess/go/vt/vttablet/tabletserver/planbuilder
            • [x] vitess/go/vt/vttablet/tabletserver/planbuilder/testdata
          • [ ] vitess/go/vt/vttablet/tabletserver/repltracker
          • [ ] vitess/go/vt/vttablet/tabletserver/rules
          • [ ] vitess/go/vt/vttablet/tabletserver/schema
            • [x] vitess/go/vt/vttablet/tabletserver/schema/schematest
          • [ ] vitess/go/vt/vttablet/tabletserver/tabletenv
            • [x] vitess/go/vt/vttablet/tabletserver/tabletenv/tabletenvtest
          • [ ] vitess/go/vt/vttablet/tabletserver/throttle
            • [ ] vitess/go/vt/vttablet/tabletserver/throttle/base
            • [ ] vitess/go/vt/vttablet/tabletserver/throttle/config
            • [ ] vitess/go/vt/vttablet/tabletserver/throttle/mysql
            • [ ] vitess/go/vt/vttablet/tabletserver/throttle/throttlerapp
          • [ ] vitess/go/vt/vttablet/tabletserver/tx
          • [ ] vitess/go/vt/vttablet/tabletserver/txlimiter
          • [ ] vitess/go/vt/vttablet/tabletserver/txserializer
          • [ ] vitess/go/vt/vttablet/tabletserver/txthrottler
          • [ ] vitess/go/vt/vttablet/tabletserver/vstreamer
            • [x] vitess/go/vt/vttablet/tabletserver/vstreamer/testenv
        • [x] vitess/go/vt/vttablet/tabletservermock
        • [ ] vitess/go/vt/vttablet/tmclient
        • [x] vitess/go/vt/vttablet/tmclienttest
        • [x] vitess/go/vt/vttablet/tmrpctest
      • [ ] vitess/go/vt/vttest
      • [ ] vitess/go/vt/vttls
      • [ ] vitess/go/vt/wrangler
        • [x] vitess/go/vt/wrangler/testdata
        • [x] vitess/go/vt/wrangler/testlib
      • [ ] vitess/go/vt/zkctl
    • [ ] vitess/go/vtbench
    • [ ] vitess/go/yaml2
    • [ ] vitess/go/zk
      • [ ] vitess/go/zk/zkctl

GuptaManan100 avatar Jan 10 '24 16:01 GuptaManan100

This is related to: https://github.com/vitessio/vitess/issues/14932

mattlord avatar Jan 10 '24 17:01 mattlord

Can you please assign me vitess/go/acl?

beingnoble03 avatar Jan 11 '24 08:01 beingnoble03

@beingnoble03 You can start working on it. When you create a PR, just mention this issue, so that if anyone else looks they know you're working on the said part.

GuptaManan100 avatar Jan 11 '24 09:01 GuptaManan100

@GuptaManan100 sure, thanks.

beingnoble03 avatar Jan 11 '24 16:01 beingnoble03

@GuptaManan100 I was trying to understand the number of LFX mentee's that is proposed to be taken for the upcoming term? Is it just 1 or multiple people would be participating in different parts of the project?

rajivharlalka avatar Jan 13 '24 10:01 rajivharlalka

On https://github.com/vitessio/vitess/pull/14935 we have seen that the coverage of planbuilder is not being reported. On the base branch it is reported as 0.00% which leads to Code coverage failure as soon as we modify the lines in this package and subpackages.

frouioui avatar Jan 15 '24 16:01 frouioui

@GuptaManan100 vitess/go/history already has 100% coverage when I run the tests locally. Can you confirm? image

EshaanAgg avatar Jan 16 '24 06:01 EshaanAgg

@GuptaManan100 vitess/go/history already has 100% coverage when I run the tests locally. Can you confirm?

@EshaanAgg, @GuptaManan100 is OOO, but I can confirm that it already has 100% of coverage on main, see the link below.

https://app.codecov.io/gh/vitessio/vitess/tree/main/go%2Fhistory

frouioui avatar Jan 16 '24 17:01 frouioui

Hey folks, I came upon this issue through the LFX Spring project idea page & interested to contribute here! From the issue, I understand that the main task is to add unit tests to various files under the project & improve test coverage (goal is 100%).

I'm a beginner in Go & have familiarity with very basic unit-testing through a personal project. I believe this would be a perfect way to level that up!

It would be a great help if you could point/list a few things out that would help me get me started here, to understand the project a bit more. Thank you

verma-kunal avatar Jan 26 '24 01:01 verma-kunal

@GuptaManan100 I've removed go/maps2 and added go/logstats from the PR description as we don't have maps2 anymore, and logstats wasn't listed.

beingnoble03 avatar May 09 '24 08:05 beingnoble03