Matjaž Horvat

Results 288 comments of Matjaž Horvat

I've made [this change](https://github.com/mozilla/pontoon/pull/3307/commits/5e27cb82cc274ceeeec25ff73acff605020d765b) after the PR was approved, which I've previously mentioned [in the comment](https://github.com/mozilla/pontoon/pull/3307#discussion_r1736962188). That way all 3 actions are logged, and we at least have some data...

Note that we have had loaders in Helper tabs in the past and dropping them improved perceived performance of the translate view. I'd only show loading indicators after a period...

Is this issue about changing the default theme for newly registered users from the [dark theme](https://github.com/mozilla/pontoon/blob/main/pontoon/base/models/user_profile.py#L34-L38) to the system theme? What about users that are not authenticated?

I think the behavior should be the same for unauthenticated users and new users. If you choose a light theme in your system settings and we honor that in Pontoon,...

For existing users everything stays the same. That [link above](https://github.com/mozilla/pontoon/issues/3339#issuecomment-2352701710) indicates that we have set the theme to "dark" for all users when the feature was shipped. The only thing...

> To confirm, would such change affect only new users registering after the change, or also existing users who never set their theme preferences? Changing the default for registered users...

I think the default must be the same for unauthenticated users and new accounts. Not sure what's the best default though - keep doing what we've been doing forever and...

To summarize, we should: * Change the default value of the `UserProfile.theme` setting to `Themes.SYSTEM`. * Honour [prefers-color-scheme](https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme) for unauthenticated users.

Dropping this here as an anecdote to support the initial claim of this issue:

> This commit addresses #3453 Please make sure you use the right keyword to link to the corresponding issue. :) Looks like the Locales and Projects sections always appear on...