Matjaž Horvat

Results 288 comments of Matjaž Horvat

Please also reference https://github.com/mozilla/pontoon/issues/3431 in the first comment if the intention is to fix that issue, too. Relatedly, if I don't enable filtering by locale and project, and target all...

@functionzz @flodolo Made a couple of CSS changes and simplified the code a little: * Widgets in collapsible filters are aligned again * Checkboxes for collapsible filters are smaller Please...

The missing data (e.g. `ProjectLocaleInsightsSnapshot.human_translations`) was last collected on January 23. Later that day we deployed [stats refactor](https://github.com/mozilla/pontoon/commit/948e6cf02b1e58e60ddd599c8e40c27a3f432fdc#diff-0ed2f4a5a57cb48d7b7cf0bb58deeaf1a6a28d8b6206c78e86cdb0fe61c7db1e), which also touched the `pontoon.insights` module. Since then, `ProjectLocaleInsightsSnapshot` data is partially...

This looks like the culprit (line 337 in `pontoon/insights/tasks.py`): https://github.com/mozilla/pontoon/commit/948e6cf02b1e58e60ddd599c8e40c27a3f432fdc#diff-2df1eab89afb639511fdb958186ff9e4b628de46aa6060ff3413c651f88b230dL337-R350 ```diff - activities, locale=project_locale.locale.id, project=project_locale.project.id + activities, locale=project_locale.locale, project=project_locale.project ```

The following functionality of the current API seems to be missing: * I cannot see the [list of locales enabled for the project](https://pontoon.mozilla.org/graphql#query=%7B%0A%20%20project(slug%3A%20%22firefox%22)%20%7B%0A%20%20%20%20localizations%20%7B%0A%20%20%20%20%20%20locale%20%7B%0A%20%20%20%20%20%20%20%20code%0A%20%20%20%20%20%20%7D%0A%20%20%20%20%7D%0A%20%20%7D%0A%7D) * Similarly, I cannot see which projects...

Thanks for the updates. Deployed to stage for testing. Looks like the parameters are missing for the `/search/tm/` endpoint on https://mozilla-pontoon-staging.herokuapp.com/api/v2/ (they appear for the `/search/terminology/` endpoint).

Nice work, I haven't found any outstanding performance regressions! Using `include_system` and `include_disabled` seems to be broken, though: ``` ProgrammingError at /api/v2/projects/ each UNION query must have the same number...

The error is gone! Apart from the terminology API response fix, is there anything else that remains to be done here?

Lowering priority further, because we no longer use DTD files in our priority projects.

The underlining issue is that we only [check](https://github.com/mozilla/pontoon/blob/de91ac809d7bd42469c8a3c9c27f7df29fd43826/pontoon/sync/vcs/models.py#L388) the first project resource and then assume all other resources in the project are of the same type (monolingual or bilingual).