Martin Grigorov

Results 774 comments of Martin Grigorov

AFAIS the queries are processed in the order from the request body JSON and there is no racing - https://github.com/meilisearch/meilisearch/blob/aefebdeb8baf85fcba538b04b010fc5d676836a4/crates/meilisearch/src/routes/multi_search.rs#L214-L240 Mistery!

@irevoire Here is the `"test"` in a shared server - https://github.com/meilisearch/meilisearch/blob/c3368e6859bef4b39621b7d4bf81f8fa215d6e34/crates/meilisearch/tests/index/create_index.rs#L50 Noice! :-)

Fixed in `dev` branch with https://github.com/meilisearch/meilisearch-rust/commit/03cec529e07c49970926cc41d897b945eb0f964f

> Do you have any experience automatically publishing containers in the GitHub registry. Probably as part of GitHub actions? Here is an example https://github.com/su2code/Docker-Builds/blob/4212d0470ba4fc203bd4bc99b801b9440ceb99e8/.github/workflows/docker-image-upload.yml#L62-L81

The build on ARM64 fails with: ``` [21/75] Building CXX object src/sortmerna/CMakeFiles/smr_objs.dir/Release/alignment.cpp.o FAILED: src/sortmerna/CMakeFiles/smr_objs.dir/Release/alignment.cpp.o /usr/bin/c++ -DCMAKE_INTDIR=\"Release\" -I/tmp/sortmerna/sortmerna-4.3.7-beta.1/include -I/tmp/sortmerna/sortmerna-4.3.7-beta.1/3rdparty/cmph -I/tmp/sortmerna/sortmerna-4.3.7-beta.1/3rdparty/concurrentqueue -I/tmp/sortmerna/sortmerna-4.3.7-beta.1/3rdparty/alp -isystem /tmp/sortmerna/sortmerna-4.3.7-beta.1/build/3rdparty/rocksdb/dist/include -isystem /tmp/sortmerna/sortmerna-4.3.7-beta.1/build/3rdparty/zlib/dist/include -W -Wextra -Wall -Xlinker -v -O3...

I am working on adding a Linux ARM64 CI at my fork - https://github.com/martin-g/sortmerna/pull/1 Once ready I will work on a fix for the compilation problem!

You miss the type - `enum` in `pub Foo`

At the moment the VM size at CircleCI (used for the linux-aarch64 builds) is `large` due to - https://github.com/bioconda/bioconda-recipes/pull/48929 - https://github.com/bioconda/bioconda-recipes/pull/46735 I've rebased this PR, so it could build the...

> Is it ok to merge now? Next time please give more details in the title and/or description of the PR!

This PR has 300+ commits. It is time to rebase your local Git clone!