ohpc icon indicating copy to clipboard operation
ohpc copied to clipboard

Upgrade OpenHPC container example with…

Open middelkoopt opened this issue 5 months ago • 6 comments

  • Contributed to OpenHPC from https://github.com/MiddelkoopT/ohpc-container
  • Updated image and container names to prepend openhpc to reduce collisions.
  • Remove old containers based on OpenHPC 2.x

middelkoopt avatar Jun 12 '25 18:06 middelkoopt

Do you have any experience automatically publishing containers in the GitHub registry. Probably as part of GitHub actions?

adrianreber avatar Jun 12 '25 18:06 adrianreber

Test Results

27 files  ±0  27 suites  ±0   37s ⏱️ -4s 53 tests ±0  49 ✅ ±0  4 💤 ±0  0 ❌ ±0  99 runs  ±0  93 ✅ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit cc8f7c67. ± Comparison against base commit 6ec75539.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jun 12 '25 18:06 github-actions[bot]

Do you have any experience automatically publishing containers in the GitHub registry. Probably as part of GitHub actions?

Not really, but I've seen it been done in the GitHub actions files I've touched. And it's not really designed for using remote containers and requires a lot of local scripts. Part of the build path is to set the container username to match the host. One option would be to publish a generic container that folks could just execute (I think the openhpc/openhpc3) and an Apptainer one as well. I did not want to make any big changes because this "just works" now and wanted to get it out.

The instructions for someone to use it would be

git clone https://github.com/openhpc/ohpc.git
cd ohpc/containers
./run.sh

middelkoopt avatar Jun 12 '25 18:06 middelkoopt

Do you have any experience automatically publishing containers in the GitHub registry. Probably as part of GitHub actions?

Here is an example https://github.com/su2code/Docker-Builds/blob/4212d0470ba4fc203bd4bc99b801b9440ceb99e8/.github/workflows/docker-image-upload.yml#L62-L81

martin-g avatar Jun 13 '25 04:06 martin-g

Thanks, I was able to adapt ones that I have been using and spent a bit more time learning. It seems to be working now. Feel free to review.

middelkoopt avatar Jun 13 '25 12:06 middelkoopt

I've since reorganized the code to handle multiple architectures correctly. I believe it is ready to be merged.

middelkoopt avatar Jun 13 '25 17:06 middelkoopt