meilisearch-rust icon indicating copy to clipboard operation
meilisearch-rust copied to clipboard

tests: Fix tests failures when testing against 1.15.1

Open martin-g opened this issue 5 months ago • 1 comments

E.g. https://github.com/meilisearch/meilisearch-rust/actions/runs/15610369450/job/43969605803?pr=625

Pull Request

Related issue

https://github.com/meilisearch/meilisearch-rust/pull/625 IT tests fail

What does this PR do?

  • Fixes tests assertions against Meilisearch 1.15.1

Summary by CodeRabbit

  • New Features

    • Added support for the /chatCompletions endpoint, enabling new actions related to chat completions.
  • Style

    • Improved clarity in test comments and simplified error messages for HTTP request failures.

martin-g avatar Jun 12 '25 13:06 martin-g

Walkthrough

The changes update a test comment and assertion in the error handling module, and add a new ChatCompletions variant to the Action enum in the key management module to support a new endpoint. No other logic or control flow modifications are present.

Changes

File(s) Change Summary
src/errors.rs Updated test comment for clarity and simplified expected error message in an assertion.
src/key.rs Added ChatCompletions variant to the Action enum with serde support for "chatCompletions".

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant KeyManager

    Client->>KeyManager: Request access for action (e.g., ChatCompletions)
    KeyManager->>KeyManager: Match action to enum variant (ChatCompletions)
    KeyManager-->>Client: Grant or deny access based on action

Poem

A hop and a skip, a new enum appears,
"ChatCompletions" joins, met with bunny cheers!
Errors made clearer, with comments refined,
This rabbit reviews with code on its mind.
🐇✨

✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jun 12 '25 13:06 coderabbitai[bot]

Fixed in dev branch with https://github.com/meilisearch/meilisearch-rust/commit/03cec529e07c49970926cc41d897b945eb0f964f

martin-g avatar Jul 10 '25 12:07 martin-g