Martin Grigorov

Results 779 comments of Martin Grigorov

@BiocondaBot please add label

**Note**: The CircleCI VM should be restored back to `medium` after merging this PR!

I added it to `host` too! Let's see!

It still behaves the same way :-/

@irevoire This one is huge! Please take a look when you have few minutes and let me know if you have any concerns! One thing that bothers me a bit...

@irevoire https://github.com/meilisearch/meilisearch/pull/5603/commits/1824fbd1b513c1b00f68f45cebdcd2c6f4252fbe introduces `Index::unique_index_with_prefix(&str)` Using it produces index names like `movies-[uuid]` in the response JSON. This way the index is both unique and readable.

@irevoire I think this big boy is ready for review! You may make yourself some🍿 ! πŸ˜„

One of the tests fails due to racing: ``` ---- search::multi::search_multiple_indexes_dont_exist stdout ---- ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot: search_multiple_indexes_dont_exist Source: crates/meilisearch/tests/search/multi/mod.rs:794 ──────────────────────────────────────────────────────────────────────────────── -old snapshot +new results ────────────┬─────────────────────────────────────────────────────────────────── 0 0 β”‚...

> But oooof that's a big bug we're never supposed to be able to create a non-unique index with the shared index and that could come from any test I...

I was using `cargo nextest` and this caused the problem with the empty list of indexes! Using `cargo test` shows a list with many entries but all of the items...