Martin Grigorov

Results 780 comments of Martin Grigorov

> Note: it also supports `inf` next to `infinity`. I see that the implementation here also supports `Inf`. The difference with the Rust PR is that here the values are...

@Gerrit0 @mkmkme Do you want to review too ?

> Perhaps renaming the function CustomAttributes::getAttributes to CustomAttributes::getAttributesJSON would do the same here. Perhaps this would be the best! In my experience (Java and Rust) the best is to keep...

Do we wait for an improvement here (deprecate the old methods and introduce new ones) ? Or the community is happy with the current solution ?

> Is this PR's merge being held up only for renaming the methods to have a "JSON" suffix? If we wanted to keep the old ones and just add new...

I have no experience with these matters and I totally depend on you here. Recently @jjatria also said that he does not have much experience with PHP, so I expected...

As I said earlier - I have no experience with PHP. I need two approvals for this PR by users of this library to merge it. So far there are...

Please remind me/us to upload the next release to https://packagist.org !