Mark Lundin
Mark Lundin
It would be good if `default` was optional
Hey @Maksims, sorry for taking so long on this. Just reviewing now, is this PR still required? it seems like the `name` property already works if it's explicitly defined or...
Modules would need to be treated differently to other scripts and loaded as `type='module'`. Additionally the current concatenation method which just appends appends files together wouldn't work as it changes...
Just thinking about this @Maksims, we can't really guarantee the loading order of ES Modules scripts. Consider the following ScriptType files: ```javascript // User specified loading order ./script-a.mjs ./script-b.mjs ./script-c.mjs...
One thing that could become more problematic is that attributes with getters/setters would not work using ScriptType ```javascript class Rotator extends ScriptType { _offset = 0; set offset (value) {...
In terms of just engine support as per https://github.com/playcanvas/engine/pull/5963, we can probably close this out now right @Maksims?
Just personally reviewing this. I'm actually leaning more towards instance based prop attributes, because that's how it currently works, and it just makes so much more sense to think of...
Thanks @Maksims. Great to get your input on this. There's still ongoing discussion around this, so we'll take this all into account as we go. > Also, class redefenition -...
Thinking about this more, we probably should focus on the primary task here, which is to add support for ES Modules, anything outside this is secondary, and it doesn't actually...
Thanks for all your input. We've outlined some more detailed design thoughts in this RFC https://github.com/playcanvas/engine/discussions/5770