Mark Lundin

Results 184 comments of Mark Lundin

Yep, that's fair, if we don't clone internally and just make it clear that the properties are assigned

I'm oversimplifying here, but ignoring events + asset/entity resolution etc, the attribute system... 1. Exposes class members to the editor 2. Validates type In an Engine only scenario, 1 is...

It has the same targets for both UMD and ES builds, so should match current outputs. I need to adjust some settings to get the build size back in line...

Below are the file sizes. Will continue investigating | Build Output | SWC | Babel/Terser | | ------------- | ------------- | ------------- | playcanvas.d.ts | 1.7MiB | 1.7MiB playcanvas.dbg.js |...

Comparison of Existing Build System vs SWC | File | Existing Gzip Size | Existing Build Time | SWC Gzip Size | SWC Build Time | |--------------------------|---------------------|---------------------|---------------|----------------| | **playcanvas.dbg.js** |...

> I've stumbled upon this ticket at rollup: [rollup/rollup#5073](https://github.com/rollup/rollup/pull/5073) > > It seems they use SWC since version 4.x. Which means, we are already using it indirectly. Is the speedup...

Not quite, `FILLMODE_WINDOW` [specifically targets the window size](https://github.com/playcanvas/engine/blob/43d0ee2ffa6e0d49dd2350bb1b9f50b717fd2c65/src/framework/app-base.js#L1267-L1284). This is just if you want a responsive canvas that fills a specific container.

If I understand correctly no, the container **would not need `position: relative`**, nor would the canvas need `position: absolute`. This is just about sizing, not positioning. An example is having...

This is more like if users are currently mutating the pc global in a project. If we don't provide a mutable global, then current projects will break. End goal is...