mark9064

Results 285 comments of mark9064

(InfiniSim PR now ready)

No numbers unfortunately - just based off how it seems. I suspect as going through the RTOS adds some waiting due to task switching etc. But equally this could be...

OK, re-abstracted to use lambdas now. If we decide to go with this approach I'll rebase the branch to be more sensible after Edit: Oh man I keep getting bitten...

I've been doing some further reading on lambdas and std::function. It looks like that if the capture list is small enough, the captured variables fit within the std::function instance and...

Just refactored the write data/command interface to be a bit nicer. The lambdas also only capture one integer now and reference static functions only which should hopefully give the compiler...

The lambda object still needs to be copied from the stack frame creating the lambda to the controller as the stack frame will be destroyed later. I did some research...

OK, I think we were both overcomplicating it! As we don't need to store the lambda anymore, we can just pass in a reference. This way it's nice and simple

Noticed I forgot to apply your naming suggestion now the semantics of the hook has changed. Corrected now

Sounds good. Let's switch to the move system if we ever need post-hooks. For now it's as simple and efficient as it can be

Can confirm NOT fixed by spi fixes in #1869 as well - this appears to be a separate issue