mark9064

Results 285 comments of mark9064

Testing on hardware now. Seems to work exactly as intended :) What do the cyan markers on 24h mode represent? If it's meant to be every other hour I find...

https://github.com/InfiniTimeOrg/InfiniTime/blob/f3d4f04827fcfe65d6647271d84590d76ce2115b/src/components/settings/Settings.h#L277 this is the line to change for settings version. As you're adding a new field to the saved settings, it becomes incompatible layout-wise with anyone's previously saved settings; this...

Yeah, when the algorithm can't find a clean signal it reports 0 Would `---` make more sense than `000`? I think that'd be better - same goes for watchfaces (they...

They are sent by bluetooth, but it's the way to go there. There's no way in the bluetooth specification to signal that there is no value available, so zero is...

For bluetooth - no, as the characteristic is standardised. Every BLE device exposing heart rate values does so in the exact same format (in the BT SIG GATT spec) On...

Let's think about only reading the heart rate characteristic for a second (rather than notifications). Bluetooth characteristics (supporting read) always have a value present. So even if the sensor is...

Since recovery mode exists, anonymous connections during normal operation could probably be disabled which resolves the root issue. It also cleans up other problems relating to open access of the...

Ah I missed that, that's a bummer. What's limiting support here? Struggling to find up to date resources on it, what I can find says that iOS should support all...

Reading that issue is honestly painful, why have apple got to make this so hard. And not even being able to tell if you're paired?? Like come on! I don't...

I'm not a core maintainer but I think in concept this looks great. All of the core devs are unfortunately tied up right now so you probably won't get a...