mwish
mwish
I've tried my best to write more testing to covering different cases, eliminate duplicate code and keep test clean. But maybe I'm not good at writing testings. If you have...
> * check and clean up CRC32 implementation to follow the code style (should be mostly mechanical) > * since we determined that the checksum may apply to all page...
@pitrou ping
(Can this patch go ahead now?)
Personally, I think we can make it easier, like using `PutImpl(std::vector, int num_values)`. When Put with arrow, we can extract it into it. Or we can: ```C++ template struct ParquetIndirectType...
(We can write a simple and slow one, and optimize it later?)
Seems the skeleton look great now. I think we can extract `Put` because now we have 4 `Put(...)` implemention now...
I've update a testing here, as an update for https://github.com/apache/arrow/pull/14341#discussion_r1149520662 ```c++ TEST(DeltaByteArrayEncodingAdHoc, ArrowDirectPut) { auto CheckEncode = [](std::shared_ptr values, std::shared_ptr prefix_lengths, std::shared_ptr suffix_lengths, std::string_view value) { auto encoder = MakeTypedEncoder(Encoding::DELTA_BYTE_ARRAY);...
LGTM now, I'm not a committer so no idea about how can this patch be merged ╮( ̄▽ ̄"")╭
@pitrou Mind take a look at this patch when you have spare time? Since it's blocked for a long time