Simon Li

Results 1067 comments of Simon Li

I discovered the pytest plugin already adds some arguments. For some reason they weren't being respected. https://playwright.dev/python/docs/test-runners#cli-arguments says it's due to us creating a new context but I couldn't get...

Except we don't require the playwright-pytest plugin.... and given that it doesn't seem to be working with our current setup there's no point at the moment. I could add options...

One option is to change the button to be a dropdown with two options: - `Stop all servers` - `Stop default servers only` and similarly for the `Start ...` button....

Thanks for the writeup. I'm pretty sure the rest of JupyterHub uses the expected behaviour that you've described (xsrf check not needed for API tokens). Please feel free to open...

It probably works on mybinder.org (as well as any BinderHub without authentication) because they don't run `jupyterhub-singleuser`: - https://github.com/jupyterhub/binderhub/blob/19b6acacea975b4a3263c49d97e65f8b8bfaa355/helm-chart/binderhub/values.yaml#L223-L249 - https://github.com/jupyterhub/binderhub/blob/19b6acacea975b4a3263c49d97e65f8b8bfaa355/binderhub/binderspawner_mixin.py#L68-L77 If authentication is enabled `cmd: jupyterhub-singleuser` is needed, and...

Is it possible to use codespell with just pre-commit, so we don't need another GitHub workflow?

We can deal with enforcing pre-commit in https://github.com/jupyterhub/jupyter-server-proxy/issues/489 I think keeping things simple and using just pre-commit is best, especially as typos should be infrequent after an initial review of...

Do you have access to the logs or monitoring on your registry server(s)?

Do you have a paid Docker account, and is anyone else using it? https://docs.docker.com/docker-hub/download-rate-limit/ | User type | Rate limit | |-|-| | Anonymous users | 100 pulls per 6...

Is the BinderHub registry token associated with the paid user account?