Simon Li

Results 1067 comments of Simon Li

Sorry for the delay. Since this is a new addition to Jupyter server proxy I think we should prioritise long term maintenance over just replicating the previous CLI- if there's...

@ryanlovett If you're generally happy with this would you mind merging https://github.com/jupyterhub/jupyter-server-proxy/pull/507 first, then we can rebase this PR, and it'll make this PR smaller, and it'll be a lot...

Up to you! I usually rebase my PRs.

I'm not a fan of adding properties just for testing, especially since we already have a lot of complicated configuration properties, and it's trivial to add a delay by subclassing...

We recently switched to redoc for the JupyterHub API on readthedocs: https://jupyterhub.readthedocs.io/en/latest/reference/rest-api.html I think it looks quite nice! It works in the way you say- the HTML code is pretty...

No it's not safe to make.... the last version of jupyter-events that runs on Python 3.8 requires version to be an integer, so we'll have to put up with the...

Rebased, https://github.com/jupyterhub/jupyterhub/pull/5182 is merged

Curl has a [`--retry` flag](https://everything.curl.dev/usingcurl/downloads/retry.html), but that won't help if it's a GitHub outage lasting several minutes.

I normally publish the advisory when the release is published. If it's easy to exploit it's probably easy for an attacker to find the vulnerability by examining recent commits if...

What version of JupyterHub and OAuthenticator are you using? Can you turn on debug logging, and show us the logs for the full authentication process?