Simon Li

Results 1067 comments of Simon Li

Is a particular spike of pods related to the same repository? Assuming your prometheus labels are the same as on Curvenote try this prometheus query for a time window around...

You're right... easily reproducible: ``` $ kubectl run xxx --image=quay.io/jupyter/datascience-notebook pod/xxx created $ kubectl get pod NAME READY STATUS RESTARTS AGE xxx 0/1 ContainerCreating 0 7s $ kubectl delete pod...

Can you try running an ephemeral pod in the same namespace, and exec something like `curl -v http://binderhub-ingress-nginx-controller/` from the pod? That should return a 404 from the Nginx controller...

For the chartpress tag problem you'll need to first run `chartpress --skip-build` to update the `set-by-chartpress` placeholders: https://github.com/jupyterhub/mybinder.org-deploy/blob/19406517c562d779999f98e70a2f33eaa662dde1/.github/workflows/cd.yml#L322-L324 The actual building and pushing of the container images is done in...

Do we need the new `template_file` property? Can't we already override the template using `template_path`? https://github.com/jupyterhub/binderhub/blob/43ecb3a8677ad4a5e0a0a70e1a0ab240f67d52dd/binderhub/app.py#L791-L798

Is the proxy JupyterHub's configurable-http-proxy, or is this some other proxy? Are you familiar with [Playwright](https://playwright.dev/)? I wonder if we could use it to automate multiple independent JupyterHub singleuser-server requests...

I think we can make a release once we know there are no issues with the new buildkit builder in mybinder.org

I've enabled this repo in pre-commit.ci

Shares are a new feature in 5.0, and would allow a user to share their server with a TA: https://jupyterhub.readthedocs.io/en/latest/reference/sharing.html If you wanted to give TAs access without user interaction...

Maybe the env-vars could be replaced by custom pytest cmdline args instead? https://docs.pytest.org/en/stable/example/simple.html#pass-different-values-to-a-test-function-depending-on-command-line-options I'll see if I can get it working.