Simon Li

Results 1067 comments of Simon Li

I tried autodoc traits originally, but it's not suitable for generating https://jupyter-server-proxy.readthedocs.io/en/latest/server-process.html because although the underlying class uses Traitlets in this particular context we're not configuring it using Traitlets. Instead...

Anyone else have thoughts on this? @stevejpurves is interested in using it.

This has been ready for 6 months, and it's effectively been in production (though being overriden in https://github.com/jupyterhub/mybinder.org-deploy/blob/b9439b5b15263ff703ea46c07bfd6c4584d1422c/config/curvenote.yaml#L59-L148) so merging!

Thanks for reviewing, I've updated the README. Though do you think we should add this, or put it in a separate action, or just document how to do it?

I don't think we have a logo, chartpress wasn't high profile enough. Could we modify https://github.com/jupyterhub/design/blob/master/assets/jupyterhub/jupyterhub-logo-square-color.svg to remove the `hub` text, and use that as a generic logo for anything...

The error message may be misleading, since the `set()` call may also return a `TypeError` even if the key exists: https://github.com/jupyterhub/oauthenticator/blob/6d08bf21445888193adee225d9749c1098af91ae/oauthenticator/oauth2.py#L1240-L1248 Can you add some debugging to show the values...

Can you provide some examples of the sensitive information you're worried about? nbgitpuller runs as the same user as the rest of JupyterLab/notebook, and all nbgitpuller parameters are passed in...

What version of TLJH did you have before you upgraded your OS?

Do you think we need to add an additional limit to BinderHub for the number of pending spawns, to prevent too many pods being created or queued up?