Simon Li
Simon Li
Yes, the code comment is incorrect, the PR comment is correct though https://github.com/jupyterhub/binderhub/pull/1544#issuecomment-1277497482 I've tried adding jupyterhub to the minimal test image before for exactly this reason, but IIRC there...
Can we treat the storage of user-info and what the authenticator controls as orthogonal issues? If we assume everything in user-info is untrusted then the Authenticator should ignore user-info completely-...
> I guess the alternative approach is to merge user_info from the db with user_info from the Authenticator somehow, such that the Authenticator-provided fields always clobber what's in the db....
What are your requirements for the integrity of these logs? Are your users fully trusted, so the logs are mostly for information? Or do the logs need to be suitable...
The integration tests are flakey, they've passed after a rerun.
According to https://jupyter.org/enhancement-proposals/108-jupyter-subdomain-for-schemas/jupyter-subdomain-for-schemas.html The schema needs to be added to https://github.com/jupyter/schema
Don't merge this https://github.com/jupyterhub/mybinder.org-deploy/issues/3053
This should be OK to merge when it's updated to the next dev version that includes https://github.com/cryptnono/cryptnono/pull/39
Failed to deploy on ovh and curvenote 😢 https://github.com/jupyterhub/mybinder.org-deploy/actions/runs/11609330331 I'll revert since those cluster are where uesr pods run so we really need cryptnono, and investigate separately
I've made a start in https://github.com/jupyterhub/jupyter-server-proxy/pull/507