Alexey Martemyanov
Alexey Martemyanov
## Checklist - [+] All tests are passed. - [-] Added tests. - [+] Documented the code using [Xcode markup](https://developer.apple.com/library/mac/documentation/Xcode/Reference/xcode_markup_formatting_ref). - [+] Searched [existing pull requests](https://github.com/ra1028/DifferenceKit/pulls) for ensure not duplicated....
Providing file path in delegate call; Allow skipping a file during unzip without breaking the whole process (cancellation with *stop=true) renamed `canceled` to `cancelled`
Task/Issue URL: https://app.asana.com/0/715106103902962/1202323846903922/f Tech Design URL: CC: @miasma13 **Description**: Custom JS alert non-blocking browser interface an allowing to close the tab https://www.figma.com/file/HZjSfXLUCIcTfDLFJAkM7h/JS-alerts?node-id=709%3A2601 - Requires product review **Steps to test this...
Task/Issue URL: https://github.com/duckduckgo/iOS/issues/1241 Tech Design URL: CC: **Description**: Improves accessibility access Fixes text color with Dark Theme in Autofill -> item Details **Steps to test this PR**: 1. Xcode ->...
Task/Issue URL: https://app.asana.com/0/414709148257752/1202193006784955/f GH Issue URL: https://github.com/duckduckgo/iOS/issues/1202 Tech Design URL: CC: @miasma13 **Description**: - Fixes loading interruption when WebView created in webView:createWebViewWithConfiguration:.. - Loading is interrupted for cleaned urls but...
Task/Issue URL: https://github.com/duckduckgo/iOS/issues/1193 Tech Design URL: CC: @miasma13 **Description**: Fixes encoding pipe argument (and other symbols) in query arguments **Steps to test this PR**: 1. Validate query arguments like space...
Task/Issue URL: https://github.com/duckduckgo/iOS/issues/1191 Tech Design URL: CC: @miasma13 **Description**: - Updated URL constructors to use BSK addParameter - Moved URL.removeParameter to BSK **Steps to test this PR**: 1. Validate ";foo"...
Original designs Implementation https://user-images.githubusercontent.com/365498/179898089-58c71039-70e0-4459-9f5f-29bb5a2b2e0e.mp4 URL for testing: https://www.w3schools.com/jsref/met_win_alert.asp use "prompt" or "confirm" functions instead of "alert" for testing different kinds of alert PR: https://github.com/duckduckgo/iOS/pull/1242
Parts lacking VoiceOver coverage: - More menu -- When the menu is shown, navigation bar, address bar and web content are still present for VoiceOver and narrated which is wrong...
Design ref:  Added 2 copy items needing localisation: "Close This Tab" (comment: "“Close this tab” button for JavaScript alerts", id: "webJSAlert.close.tab.button") "A message from %@:" (comment: "Alert title explaining...