iOS icon indicating copy to clipboard operation
iOS copied to clipboard

Fix Incorrect URL query parameters encoding mechanism

Open mallexxx opened this issue 3 years ago • 0 comments

Task/Issue URL: https://github.com/duckduckgo/iOS/issues/1191 Tech Design URL: CC: @miasma13

Description:

  • Updated URL constructors to use BSK addParameter
  • Moved URL.removeParameter to BSK

Steps to test this PR:

  1. Validate ";foo" search request works as expected

Copy Testing:

  • [ ] Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • [ ] Portrait
  • [ ] Landscape

Device Testing:

  • [ ] iPhone SE (1st Gen)
  • [ ] iPhone 8
  • [ ] iPhone X
  • [ ] iPad

OS Testing:

  • [ ] iOS 13
  • [ ] iOS 14
  • [ ] iOS 15

Theme Testing:

  • [ ] Light theme
  • [ ] Dark theme

Internal references:

Software Engineering Expectations Technical Design Template When ready for review, remember to post the PR in MM

mallexxx avatar Jun 14 '22 11:06 mallexxx