Alexey Martemyanov
Alexey Martemyanov
Closing this due to Design Review completed
Thanks @Bunn, this should be ready for review now
Thanks once again :) Done
@bwaresiak valid concern, what do you think about refactoring the CBR/UserScripts loading to Publishers sequence and waiting for CBRs to finish compiling in decidePolicyForNavigationAction?
I made an initial effort refactoring the ContentBlockingRules to async waiting and loading as a single asset; @bwaresiak when you have time please check and we‘ll have a chat to...
@bwaresiak I updated the Attribution logic to match the latest macOS implementation, now this scenario seems working as it should
@bwaresiak this should be ready for another pass now; I‘ve made the changes you requested and added instant recreation on recursive alerts detection and multiple navigation requests Opened test pages...
TODO: make it explicit in DEBUG
@bwaresiak as discussed, I've added DEBUG log instructions on how to disable the termination behaviour and a breakpoint to make sure it gets noticed
@Bunn, I fixed some translations: used https://github.com/mozilla-mobile/firefox-ios as a source (Shared/xx.lproj/Localizable.strings:"HomePanel.ContextMenu.Bookmark"), can you give it another pass please?