iOS icon indicating copy to clipboard operation
iOS copied to clipboard

Fix popup tab loading interruption

Open mallexxx opened this issue 3 years ago • 0 comments

Task/Issue URL: https://app.asana.com/0/414709148257752/1202193006784955/f GH Issue URL: https://github.com/duckduckgo/iOS/issues/1202 Tech Design URL: CC: @miasma13

Description:

  • Fixes loading interruption when WebView created in webView:createWebViewWithConfiguration:..
  • Loading is interrupted for cleaned urls but managed by a creator tab otherwise
  • This fixes an issue of Printing not working on a new tab created for printing

Steps to test this PR:

  1. Validate print works on https://www.theenglishkitchen.co/2009/09/beer-battered-fish.html?m=1
  2. Validate links opened in new tab work (e.g. in yandex search)
  3. Validate pop-up windows created with js work

Internal references:

Software Engineering Expectations Technical Design Template When ready for review, remember to post the PR in MM

mallexxx avatar Jun 20 '22 10:06 mallexxx