Naser Mahfouz
Naser Mahfouz
Done in https://github.com/E3SM-Project/scream/pull/3086 pls (everyone here) reopen if you disagree :) thanks
@AaronDonahue gentle note: The "fixes" syntax in github is a bit specific (see https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests). Of note, "addresses" isn't a recognized keyword and the issue number must be right after the...
> > Good start, but I don't think we should integrate this as-is. Feel free to push back... I think we should be strive to unify our approach with the...
> @mahf708 the CI testing is running even though this a draft PR. Can we change that? Yes We Can @xylar, I think specifying the type will do, but like...
@rljacob: I think we may want to move to labels-based testing (especially if we implement the self-hosted solution). (@xylar, for reference, https://github.com/mahf708/test-gh-runner-chrys/actions/runs/10409947659 ran on a chrysalis login node)
> Why does github think its a new file if its the same name in the same directory? They are two different files... sorry I had the wrong code block...
> For a standalone test, say, `homme_shoc_cld_p3_rrtmgp_np1` , dp is not init-ed properly before homme when compute_current_energy is called. we'll try to fix that. You can also add a new...
Note: this will require some code edits in ekat
xref https://github.com/E3SM-Project/E3SM/issues/5953 --- I hope we can fix that too when we fix this. In general, I find the P3 table business to be quite complicated and caused a bit...
Yes; also my understanding is that the whole table could actually be calculated at runtime ...