Naser Mahfouz

Results 181 comments of Naser Mahfouz

> @mahf708 , thanks for making the table in the PR description work. My original mark down didn't work out well so I had to manually insert some blank space...

Thanks, cmake options (only for pm-cpu and pm-gpu) should also be edited. I would suggest: - introduce the ML option and set it to OFF by default - activate the...

Sorry, I didn't see @ndkeen's comment above. I defer to Noel to make the final decision on all of this, so I will dismiss my own review :) It's my...

Yeah, just to lessen the pressure on the server

No longer planned because we have removed this test entirely for now.

Yeah, that's fine. The "conventional" (e.g., EAM) behavior is exactly this: > if the run starts at 2000-01-01-00000, and output is INSTANT every 5 min, the first file will have...

> I found out EAM puts t0 output in its own file. Hmmm. I don't think this is the default behavior... I've never seen it!

> It seams to be a restart problem, and the closest issue i can find in this one. I think it's the same general issue (and my motivation to open...

due to https://github.com/E3SM-Project/scream/blob/be44997581059f0e4dcc400323844c8b18195b88/components/eamxx/src/share/field/field_impl.hpp#L316