Naser Mahfouz

Results 181 comments of Naser Mahfouz

> @mahf708 Have you tried implementing the suggestion in my last comment? I don't have a macos machine, so I can't test it quickly (and not quick => not doing...

No, linux is enough for the foreseeable future

Update: I could get this built with either of the edits above, but only for static linking. For shared builds, I get the following error: ``` [ 52%] Linking CXX...

we should add a few small minor edits related to p3 in here too

Now ready, @whannah1, how does this look to you? -- once we are ready, we can add the corresponding specifics for other grids. Leave auto/accr/cldfrac unchanged by default, but importantly...

> > Does it make sense to change same settings for ne512 at same time? > > I don't think so - we have a plan to test modified values...

This should be ready. Someone will need to take care of the blessing business once merged...

yeah, looks good from a quick skim. Everything that has p3 active should DIFF. If you're doubtful about any specific test, let me know

Since we have a variety of integrators with various levels of gh appetite, I think this is the type of thing that can be disruptive for some... I like it...