Naser Mahfouz

Results 181 comments of Naser Mahfouz

Yeah, I was testing with release/tests/multi-process/physics_only/shoc_cld_spa_p3_rrtmgp with the collapsed code example python code ```py import numpy as np import xarray as xr from matplotlib import pyplot as plt ds =...

Thanks for double checking! It's time to switch back yes! Let's keep this issue open until I switch back for the few places I am doing the longer calc

Tangentially related: I just tested requesting z_mid inside of nudging via add_field and got all zeros. Patch below on top of very recent codebase for the lengthy z_mid calc needed...

If someone picks this up, pls keep the workflow_dispatch, and at any rate, pls request review from or at least tag both luca (@bartgol) and me (@mahf708) to review the...

> I thought that in your action, as it was written (or, maybe, as I read it) there was no real need for dispatch trigger. The only reason for that...

The ability to manually trigger action runs is important in my experience. I personally made use of it quite a bit. For example when Oksana and Andrew were fixing the...

These are valid points :) I think I agree with you that in the long term (i.e., once we move a lot more of our testing to the gh/ci infra),...

> I think we can make diags tell IO whether they may generate mask/fill values. Yes, this is what I meant by "handle fillval" / "track accumulation" --- tell the...

> Being false by default, all diags that do not generate invalid values don't need to be modified. But FieldAtHeight or AodVis can return true. IO will then take care...

I will get a PR done soon (likely over the weekend)