Madelyn Olson

Results 617 comments of Madelyn Olson
trafficstars

Since the new test is a bit odd, running the daily against a bunch of different platforms. https://github.com/valkey-io/valkey/actions/runs/10530596918

>I thought about that. I don't see this PR being needed for back-porting to 7.X. And if we are making refectoring changes, it will be good to keep 8.0 and...

Is this really all that important now that modules can natively integrate with the config system now?

@lipzhu Would be great if you could take a look as well.

For now I'm inclined to say let's wait and see how it get's used. There will likely be large swings in memory usage if you are using tracking, but they...

@ranshid What is the value of having this be a subcommand? I feel like the previous Redis folks went overzealous about subcommands and made everything a subcommand. Given this is...

@valkey-io/core-team Please vote on adding this new argument to cancel on ongoing save. This is useful for admins.

This title isn't right, it's removing that it's a protected config, which has wider implications that just making it a mutable config. Making it protected doesn't make sense, was there...

> I don't remember the exact context now but I guess "protected" was introduced as a guard rail to prevent "fat-fingering" while keeping the config mutable. In a sense, this...

From core discussion, let's document that the sync finishes the replication with dual channel even when the flag is flipped part way through. (Ideally it should finish with the initial...