Madelyn Olson

Results 613 comments of Madelyn Olson
trafficstars

> Forked repositories have recurring workflows disabled by default so that shouldn't be needed. You aren't wrong. I'm not exactly sure of the history of that feature, but we didn't...

@jonathanspw Can you fix the DCO check (sign-off on the last three commits). Otherwise I can do it since you were taking my changes.

@jonathanspw I'm sorry, I pushed the wrong branch to your unstable branch and github did not appreciate that (and closed the PR, so I can't update it anymore). Would you...

> Hmm I didn't notice there's a piece in normal CI that does a build on CentOS 7. If you'll give me a minute I can add a commit that...

This makes sense to me. We talked about fixing this in the past but never did anything about it, so I think a contribution is welcome since this is practically...

> Wouldn't this cause some inconsistency if some keys of the rdb file is loaded and some keys are discarded? For a cache it may be fine but for a...

I was waiting on performance numbers from Hari before officially adding it.

@hpatro AFAIK most of the folks are inclined to accept it for 8, so I would ask you to follow up if you can. I'll throw it on our Monday...

> @madolson I can't see any other builds apart from DCO check. Are we throttled/out of credits? You have a merge conflict..

I see 4/6 people directionally inclined, so going to throw on the directionally approved tag.