Anonymous Maarten

Results 735 comments of Anonymous Maarten

> /path/to/SDL-git/test/checkkeys.c:237:17: warning: incompatible pointer types initializing 'const bool *' with an expression of type 'const unsigned char *' [-Wincompatible-pointer-types] Do these warnings still appear? This looks like `bool` was...

I updated my emsdk, and I can reproduce your warning: ``` /home/maarten/projects/SDL/test/checkkeys.c:237:17: warning: incompatible pointer types initializing 'const bool *' with an expression of type 'const unsigned char *' [-Wincompatible-pointer-types]...

This is what happens: the tests are built in `--std=c90` mode, with GNU extensions disabled. So `__STDC_VERSION__` is not defined, and we do `#define bool unsigned char` in `SDL3/SDL_stdinc.h`. https://github.com/libsdl-org/SDL/blob/c2121dd9a2b3144f1a76c71066adfb782ab72eeb/include/SDL3/SDL_stdinc.h#L47-L58...

See https://github.com/libsdl-org/SDL/pull/11772

I think we don't have to worry about a properties object being destroyed from under you while it is in use: SDL borrows it during the Create and Get function...

The actions log of https://github.com/libsdl-org/SDL/issues/11487#issuecomment-2481539175 contains the following lines, so [the `gameinput.h` test succeeds](https://github.com/libsdl-org/SDL/blob/aa352837d55405fee45fa9cb308f1239990cb4a3/CMakeLists.txt#L1899-L1904) ```cmd -- Performing Test HAVE_GAMEINPUT_H -- Performing Test HAVE_GAMEINPUT_H - Success ``` So it's very weird...

[MSVC succeeded](https://github.com/ChillerDragon/SDL_image/actions/runs/11927512772/job/33242991330) because you are using an [older Windows runner image](https://github.com/ChillerDragon/SDL_image/actions/runs/11927512772/job/33242991330#step:1:9): 20241021.1.0 You need 20241113.x (or newer). Restart the job until you get the newer one.

https://github.com/actions/runner-images/issues/10980#issuecomment-2513163023 > I think there's something wrong with either the MSBuild files or the CMake Visual Studio generator on the runner image. Switching to the Ninja CMake generator does not...

The resolution of https://github.com/actions/runner-images/issues/10980 was to use windows-2025

These tests can be found in the main CMakelists, if you grep for the name of the symbols. [For](https://github.com/libsdl-org/SDL/blob/main/cmake/PreseedMSVCCache.cmake) [a](https://github.com/libsdl-org/SDL/blob/main/cmake/PreseedEmscriptenCache.cmake) [few](https://github.com/libsdl-org/SDL/blob/main/cmake/PreseedNokiaNGageCache.cmake) toolchains, we preseed the cache, causing these tests to...