Anonymous Maarten

Results 735 comments of Anonymous Maarten

I'm currently experimenting with turning `SDL_ELF_NOTE_DLOPEN` in a non-variadic macro like so: ```c #define SDL_ELF_NOTE_DLOPEN(feature, description, priority, libs) \ SDL_ELF_NOTE_INTERNAL( \ "[{\"feature\":\"" feature \ "\",\"description\":\"" description \ "\",\"priority\":\"" priority \...

If we don't find a way, I would remove the following lines from `SDL_dlopennote.h`: https://github.com/libsdl-org/SDL/blob/281ac6c3bb619f614616a82891c3e39d3f05ceea/include/SDL3/SDL_dlopennote.h#L218-L219 Projects can still use the `SDL_ELF_NOTE_DLOPEN` freely. It's only when they want to provide compatibility...

I'll remove the line(s), can you first check whether you can get [this suggestion](https://github.com/libsdl-org/SDL/issues/14214#issuecomment-3393716129) working? If if's viable, then we can avoid a build breaking change.

> Can you attach a patch? (yeah, I'm lazy) Sure, but I think simply copy/pasting that code in `SDL3/SDL_dlopennote.h` is easier :) ```patch --- a/include/SDL3/SDL_dlopennote.h +++ b/include/SDL3/SDL_dlopennote.h @@ -201,12 +201,12...

Ok, the patch is little bit more complicated when you can remove the exceptions for older gcc etc: ```patch diff --git a/include/SDL3/SDL_dlopennote.h b/include/SDL3/SDL_dlopennote.h index da145eed5..9c8c3e207 100644 --- a/include/SDL3/SDL_dlopennote.h +++ b/include/SDL3/SDL_dlopennote.h...

I'm currently on Windows and did not realize the patch was incomplete for Linux: [patch.txt](https://github.com/user-attachments/files/22875047/patch.txt)

Another alternative could be to require the last argument to be a C string, representing a javascript JSON list: e.g. ```c SDL_ELF_NOTE_DLOPEN( "png", "Support for loading PNG images using libpng",...

The macro is currently called `SDL_ELF_NOTE_DLOPEN`, but the header is called `SDL_dlopennote.h`. Do we want to keep the `ELF` in the macro?

> One thing that can be done is, not including SDL_dlopennote.h in SDL.h by default and manually include it where it is actually used. That would prevent most accidents. You...

Are you using SDL3 from git? The SDL 3.2.x releases are missing crucial functionality, and is also a major cause SDL3_mixer is not yet released.